Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] esm: increase test coverage of edge cases #47433

Closed
wants to merge 1 commit into from
Closed

[v18.x backport] esm: increase test coverage of edge cases #47433

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 5, 2023

Backport of #47033

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v19.x labels Apr 5, 2023
@RafaelGSS RafaelGSS force-pushed the v19.x-staging branch 4 times, most recently from 9ffffca to 8e1e9ed Compare April 8, 2023 18:21
@aduh95 aduh95 changed the base branch from v19.x-staging to v18.x-staging May 2, 2023 12:21
@aduh95 aduh95 changed the title [v19.x backport] esm: increase test coverage of edge cases [v18.x backport] esm: increase test coverage of edge cases May 2, 2023
@aduh95
esm: increase test coverage of edge cases
7352e31 
PR-URL: nodejs#47033
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@aduh95 aduh95 force-pushed the esm-edge-cases branch from 93a07d0 to 7352e31 Compare May 2, 2023 12:26
@aduh95 aduh95 added v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. and removed v19.x labels May 2, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51839/

This was referenced May 18, 2023
Open
Open
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51995/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51997/

@github-actions github-actions bot mentioned this pull request May 30, 2023
Open
23 tasks
danielleadams pushed a commit that referenced this pull request May 30, 2023
@aduh95 @danielleadams
esm: increase test coverage of edge cases
b749323 
PR-URL: #47033
Backport-PR-URL: #47433
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@danielleadams
Copy link
Contributor

Landed in b749323

This was referenced May 31, 2023
Open
Open
This was referenced Jun 3, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleadams danielleadams danielleadams approved these changes

Assignees
No one assigned
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aduh95 @nodejs-github-bot @danielleadams