Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] test: remove useless require('../common') from WPTs #47506

Closed
wants to merge 1 commit into from
Closed

[v18.x backport] test: remove useless require('../common') from WPTs #47506

wants to merge 1 commit into from

Conversation

panva
Copy link
Member

@panva panva commented Apr 11, 2023

Backports #46796

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Apr 11, 2023
@panva panva marked this pull request as ready for review April 11, 2023 08:15
panva added a commit to panva/node that referenced this pull request Apr 11, 2023
@panva
test: remove useless require('../common') from WPTs
1e37b3e 
PR-URL: nodejs#46796
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Backport-PR-URL: nodejs#47506
@panva panva force-pushed the requested-backports-v18.x branch from c493699 to 1e37b3e Compare April 11, 2023 08:16
@panva panva requested a review from danielleadams April 11, 2023 08:16
@panva panva mentioned this pull request Apr 11, 2023
Merged
panva added a commit to panva/node that referenced this pull request Apr 11, 2023
@panva
test: remove useless require('../common') from WPTs
b4e645d 
PR-URL: nodejs#46796
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Backport-PR-URL: nodejs#47506
@panva panva force-pushed the requested-backports-v18.x branch from 1e37b3e to b4e645d Compare April 11, 2023 13:26
@panva
test: remove useless require('../common') from WPTs
2699cd2 
PR-URL: nodejs#46796
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Backport-PR-URL: nodejs#47506
@panva panva force-pushed the requested-backports-v18.x branch from b4e645d to 2699cd2 Compare April 12, 2023 11:32
@panva panva mentioned this pull request Apr 12, 2023
Merged
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 12, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51152/

@danielleadams
Copy link
Contributor

@panva I don't know if this will make the release since the tests are still running, but I can land this after the release goes out so that it's ready for the next one.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51157/

danielleadams pushed a commit that referenced this pull request May 17, 2023
@panva @danielleadams
test: remove useless require('../common') from WPTs
843ecd2 
PR-URL: #46796
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Backport-PR-URL: #47506
@danielleadams
Copy link
Contributor

Landed in 843ecd2

@panva panva deleted the requested-backports-v18.x branch May 17, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleadams danielleadams danielleadams approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panva @nodejs-github-bot @danielleadams @lpinca