Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools, test: enable space-in-parens ESLint rule #4753

Closed
wants to merge 2 commits into from
Closed

tools, test: enable space-in-parens ESLint rule #4753

wants to merge 2 commits into from

Conversation

silverwind
Copy link
Contributor

This came up in #4743 (comment). There were only 7 violations, all of them in test.

@silverwind silverwind added the tools Issues and PRs related to the tools directory. label Jan 19, 2016
@silverwind silverwind added the test Issues and PRs related to the tests. label Jan 19, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Jan 19, 2016

LGTM

1 similar comment
@evanlucas
Copy link
Contributor

LGTM

silverwind added a commit that referenced this pull request Jan 19, 2016
@silverwind
tools: enable space-in-parens ESLint rule
6588a70 
Ref: http://eslint.org/docs/rules/space-in-parens.html
PR-URL: #4753
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
silverwind added a commit that referenced this pull request Jan 19, 2016
@silverwind
test: fix issues for space-in-parens ESLint rule
647861b 
PR-URL: #4753
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@silverwind
Copy link
Contributor Author

Thanks, landed in 6588a70 and 647861b.

@silverwind silverwind closed this Jan 19, 2016
@evanlucas evanlucas mentioned this pull request Jan 19, 2016
Merged
evanlucas pushed a commit that referenced this pull request Jan 19, 2016
@silverwind @evanlucas
tools: enable space-in-parens ESLint rule
c33f6a8 
Ref: http://eslint.org/docs/rules/space-in-parens.html
PR-URL: #4753
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
evanlucas pushed a commit that referenced this pull request Jan 19, 2016
@silverwind @evanlucas
test: fix issues for space-in-parens ESLint rule
9926b5a 
PR-URL: #4753
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
evanlucas pushed a commit that referenced this pull request Jan 20, 2016
@silverwind @evanlucas
tools: enable space-in-parens ESLint rule
8f4f5b3 
Ref: http://eslint.org/docs/rules/space-in-parens.html
PR-URL: #4753
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
evanlucas pushed a commit that referenced this pull request Jan 20, 2016
@silverwind @evanlucas
test: fix issues for space-in-parens ESLint rule
a39b28b 
PR-URL: #4753
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Jan 28, 2016
@silverwind
test: fix issues for space-in-parens ESLint rule
8557c39 
PR-URL: #4753
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Jan 28, 2016
@silverwind
tools: enable space-in-parens ESLint rule
f25006a 
Ref: http://eslint.org/docs/rules/space-in-parens.html
PR-URL: #4753
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
@silverwind
test: fix issues for space-in-parens ESLint rule
94d4765 
PR-URL: #4753
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
@silverwind
tools: enable space-in-parens ESLint rule
2046400 
Ref: http://eslint.org/docs/rules/space-in-parens.html
PR-URL: #4753
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
@silverwind
test: fix issues for space-in-parens ESLint rule
f60ace8 
PR-URL: nodejs#4753
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
@silverwind
tools: enable space-in-parens ESLint rule
faf1ff1 
Ref: http://eslint.org/docs/rules/space-in-parens.html
PR-URL: nodejs#4753
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@MylesBorins MylesBorins mentioned this pull request Feb 11, 2016
Merged
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 13, 2016
@silverwind @MylesBorins
test: fix issues for space-in-parens ESLint rule
1d3d2f1 
PR-URL: nodejs#4753
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 13, 2016
@silverwind @MylesBorins
tools: enable space-in-parens ESLint rule
c47a90e 
Ref: http://eslint.org/docs/rules/space-in-parens.html
PR-URL: nodejs#4753
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 15, 2016
@silverwind
test: fix issues for space-in-parens ESLint rule
447347c 
PR-URL: nodejs#4753
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 15, 2016
@silverwind
tools: enable space-in-parens ESLint rule
837ebd1 
Ref: http://eslint.org/docs/rules/space-in-parens.html
PR-URL: nodejs#4753
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@silverwind
tools: enable space-in-parens ESLint rule
403c7e1 
Ref: http://eslint.org/docs/rules/space-in-parens.html
PR-URL: nodejs#4753
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@silverwind
test: fix issues for space-in-parens ESLint rule
0dfc936 
PR-URL: nodejs#4753
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @cjihrig @evanlucas @MylesBorins