Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update darwin-x64 toolchain used for Node.js 20 releases #47546

Merged
merged 2 commits into from
Apr 14, 2023
Merged

doc: update darwin-x64 toolchain used for Node.js 20 releases #47546

merged 2 commits into from
Apr 14, 2023

Conversation

targos
Copy link
Member

@targos targos commented Apr 13, 2023

Refs: #47067

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Apr 13, 2023
@targos
Copy link
Member Author

targos commented Apr 13, 2023

/cc @RafaelGSS this documents a change we made in the release CI for v20.0.0

@targos targos added dont-land-on-v14.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Apr 13, 2023
richardlau
richardlau reviewed Apr 13, 2023
View reviewed changes
BUILDING.md Outdated Show resolved Hide resolved
@richardlau richardlau added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 13, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @richardlau. Please 👍 to approve.

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2023
@nodejs-github-bot nodejs-github-bot merged commit 503d838 into nodejs:main Apr 14, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 503d838

targos added a commit that referenced this pull request May 2, 2023
@targos
doc: update darwin-x64 toolchain used for Node.js 20 releases
f9abd59 
Refs: #47067
PR-URL: #47546
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@targos targos mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @nodejs-github-bot @gengjiawen @richardlau @RafaelGSS