Null-proofing in files_watcher

[sosoba]

Regardles to documentation:

filename is not always guaranteed to be provided. Therefore, don't assume that filename argument is always provided in the callback, and have some fallback logic if it is null.

Fix for #47692

[MoLow]

@sosoba you will also need to remove the merge commits, see https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-5-rebase

[MoLow]

additionally if you have a repro can you add it as a test?

[sosoba]

additionally if you have a repro can you add it as a test?

Unfortunately not. The program that generated the event:

{eventType: 'change', fileName: null}

while running node --watch at the same time is not open code..

[sosoba]

@sosoba you will also need to remove the merge commits, see https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-5-rebase

Rebased.

[MoLow]

Unfortunately not. The program that generated the event:

then please add a test case to https://github.com/nodejs/node/blob/main/test/parallel/test-watch-mode-files_watcher.mjs