Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: fix ERR_NOT_BUILDING_SNAPSHOT is not a constructor #47721

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

legendecas
Copy link
Member

Adds a regression test verifying that the error is correctly constructed.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 26, 2023
@legendecas legendecas added the snapshot Issues and PRs related to the startup snapshot label Apr 26, 2023
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 27, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 27, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@legendecas legendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 28, 2023
@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 29, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/47721
✔  Done loading data for nodejs/node/pull/47721
----------------------------------- PR info ------------------------------------
Title      v8: fix ERR_NOT_BUILDING_SNAPSHOT is not a constructor (#47721)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     legendecas:startup/err -> nodejs:main
Labels     author ready, needs-ci, snapshot
Commits    1
 - v8: fix ERR_NOT_BUILDING_SNAPSHOT is not a constructor
Committers 1
 - Chengzhong Wu 
PR-URL: https://github.com/nodejs/node/pull/47721
Reviewed-By: Joyee Cheung 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47721
Reviewed-By: Joyee Cheung 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 26 Apr 2023 07:37:04 GMT
   ✔  Approvals: 1
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/47721#pullrequestreview-1402519179
   ✘  This PR needs to wait 87 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-04-27T12:15:31Z: https://ci.nodejs.org/job/node-test-pull-request/51507/
- Querying data for job/node-test-pull-request/51507/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4839548131

@legendecas legendecas added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit bddf341 into nodejs:main Apr 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in bddf341

targos pushed a commit that referenced this pull request May 2, 2023
PR-URL: #47721
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request May 2, 2023
targos pushed a commit that referenced this pull request May 3, 2023
PR-URL: #47721
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@legendecas legendecas deleted the startup/err branch May 4, 2023 03:31
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47721
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#47721
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. snapshot Issues and PRs related to the startup snapshot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants