doc: add copy node executable guide on windows #47781
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
|
Review requested:
|
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
RaisinTen
added
author ready
debadree25
approved these changes
May 1, 2023
debadree25
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/47781 ✔ Done loading data for nodejs/node/pull/47781 ----------------------------------- PR info ------------------------------------ Title doc: add copy node executable guide on windows (#47781) Author XLor (@yjl9903, first-time contributor) Branch yjl9903:patch-3 -> nodejs:main Labels doc, author ready, commit-queue-squash, single-executable Commits 11 - doc: add copy node executable guide on windows - doc: fix powershell typo - doc: fix related hello.exe in commands of sea doc - doc: fix copy executable step reference - doc: remove extra space - doc: splite long lines - doc: remove note that - doc: fix ApplicationInfo.Source property - doc: add copy node windows cmd command - doc: fix extra space lint error - doc: rename with command prompt Committers 2 - XLor - GitHub PR-URL: https://github.com/nodejs/node/pull/47781 Reviewed-By: Darshan Sen Reviewed-By: Debadree Chatterjee ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47781 Reviewed-By: Darshan Sen Reviewed-By: Debadree Chatterjee -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 29 Apr 2023 11:52:48 GMT ✔ Approvals: 2 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/47781#pullrequestreview-1407376967 ✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/47781#pullrequestreview-1407383127 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient ⚠ PR author is a new contributor: @yjl9903(xlor@onekuma.cn) ⚠ - commit 904b818c016a is authored by yjl9903@onekuma.cn -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4850921129 |
|
Landed in d225d95 |
debadree25
pushed a commit
that referenced
this pull request
May 1, 2023
PR-URL: #47781 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
|
Thank you for your contribution @yjl9903 🎉❤️ |
targos
pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47781 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 3, 2023
PR-URL: #47781 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
danielleadams
added
the
backport-blocked-v18.x
|
Blocked by #47125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
In single-executable, copyied node executable on windows should be named with extension .exe, this PR added some guides about it.
Related discussion nodejs/single-executable#65
Sorry for reopen this PR so many times for that I made some mistakes when rebasing and not sure how to recover :(