Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix --allow-* CLI flag references #47804

Merged
merged 1 commit into from
May 1, 2023

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented May 1, 2023

The brackets were escaped for some reason, preventing them from being rendered as links, and the link targets were not defined.

screenshot of how the relevant doc section is currently rendered

@tniessen tniessen added cli Issues and PRs related to the Node.js command line interface. fast-track PRs that do not need to wait for 48 hours to land. labels May 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Fast-track has been requested by @tniessen. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 1, 2023
@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 1, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 1, 2023
@nodejs-github-bot nodejs-github-bot merged commit 798db3c into nodejs:main May 1, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 798db3c

targos pushed a commit that referenced this pull request May 2, 2023
PR-URL: #47804
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@targos targos mentioned this pull request May 2, 2023
targos pushed a commit that referenced this pull request May 3, 2023
PR-URL: #47804
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@danielleadams danielleadams added the dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. label Jun 29, 2023
@tniessen tniessen added the permission Issues and PRs related to the Permission Model label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. fast-track PRs that do not need to wait for 48 hours to land. permission Issues and PRs related to the Permission Model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants