-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade npm to 2.2.0 #479
Conversation
@othiym23 one small technical problem with this PR is that we've overwritten install.js and build.js in node-gyp in the io.js repo and we'll need to redo that after this merge. Can I suggest either:
Onto the topic of npm upgrade process though, I think I'd like to propose the following to the TC about npm (I don't think we've discussed this in a meeting yet?):
|
@@ -1,3 +1,34 @@ | |||
### v2.2.0 (2015-01-08): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh look .. here's a changelog for us, I retract that comment about needing a changelog then
I'd much rather @TooTallNate merge your PR and then install the patched version into npm, but if that takes a while, it makes more sense for npm to take that as a floating patch than to have to keep applying it in the io.js repo. If we do decide to do this with a floating patch, the things I pointed out on nodejs/node-gyp#564 apply to the patch for npm as well. Given that @TooTallNate just landed a patch to
I am happy to act as a point of contact between the io.js and npm CLI teams, but I'm also happy to just submit new npm versions as PRs. Commit access isn't really necessary, especially given the review, test, and feedback cycle you propose (which all sounds sensible to me). If you feel that it's easier to do it this way, I have no objections, but it's not required.
You already found
Absolutely. I'd like to allow io.js and npm to have their own release cadences, without the release of one requiring a scramble to include the latest release of the other. It's rare that it's necessary that the absolutely newest version of npm go out with a new Node or io.js release. It used to be a bigger deal, but the weekly release train and the split between
The npm CLI team has a rewrite of the npm test suite to be more comprehensive and less squirrelly reasonably high on its list of priorities. Reducing test suite run time, being able to meaningfully gauge coverage, and getting all the tests running under |
@rvagg I think we can just float our node-gyp patches on top of upgrades for now, like we do with V8. If you agree, I can land this PR and the patches (or maybe @othiym23 can cherry-pick them, if he feels like it.) By the way, I appreciate that you've started upstreaming our changes! @othiym23 If I can make a request, would it be possible to include a small changelog in the commit log with just the highlights since the last upgrade? That would make it easier for us to put release notes together. Or should we just copy/paste from CHANGELOG.md? |
I'll do this. Cherry-picking them onto the PR is actually better than sticking them into npm proper, given that my hope is that eventually npm can just upgrade to a Node / iojs-agnostic version of
I'm happy to make an even more compressed abstract of the changes for the purposes of io.js, but the contents of I'll try a 2 or 3-line summary for the next few releases and y'all can decide if that's what you want. npm is going to be going through a lot of minor version bumps for the next month or two as we land the various pieces of CLI support for the new registry features, so this should be a good way to get a feel about where the terseness / completeness know should be turned. |
Apply a small patch that makes node-gyp fetch the tarballs from https://iojs.org/ instead of http://nodejs.org/ A patch better suited for inclusion upstream will be put together shortly. PR-URL: nodejs#343 Reviewed-By: Rod Vagg <rod@vagg.org>
* Fetch from the correct url. * Link compiled addons with iojs.lib instead of node.lib. * Disable checksum checks for iojs.lib until our website supports them. PR: nodejs#422 Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-by: Rod Vagg <rod@vagg.org>
I've cherry-picked those two patches in there, and am happy to squash via rebase – not really sure what the policy is on reapplying previous patches. |
We normally keep floating patches separate. LGTM. @rvagg? |
lgtm, @bnoordhuis you can land this then this along with V8 4.1 are looking like a 1.0.3 |
PR-URL: #479 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org>
Thanks @othiym23, landed in 9dc8f59...1952219. |
Unless the TC would prefer that I adopt a different process, I'll start submitting PRs with the latest versions of npm as soon as they're promoted to
npm@latest
. Feel free to only land the ones that will make it into io.js releases.If you aren't familiar with the npm release process, the tl;dr is that npm follows a simple release train model, with a new testing release (
npm@next
) published every Thursday, and the previous week's testing release promoted to stable (npm@latest
, or justnpm
). It also wouldn't be that tough for us to automate this process, should @rvagg The Buildmaster (that's like a Beastmaster, but with less Marc Singer) decide that makes sense.