-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url: call ada::can_parse
directly
#47919
Conversation
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This opens up future optimization opportunities.
@nodejs/build I couldn't understand the root cause of the error in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but looks like there's an asan issue in ada::url that needs looking at.
Because the ASan output is massive and the relevant part can be hard to find, here's a link to the relevant part: https://github.com/nodejs/node/actions/runs/4929741771/jobs/8809762438?pr=47919#step:6:5394 Be patient while it loads. The relevant line starts with |
Ugh, that link didn't work. You need to scroll back up to line 5393. |
@lemire do you have any idea about the root cause of this error? |
@Trott I suspect it is not in ada that we have a memory error. See my comment above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Landed in 8b6947f |
PR-URL: nodejs#47919 Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #47919 Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
We're planning on improving the performance of
ada::can_parse
and added this function in2.3.1
release. This would make things a lot easier and more readable for Node.js.cc @KhafraDev @nodejs/url