test: remove race condition in http flood test #4793
Conversation
Timer race results in some flakiness on slower devices in CI.
Trott
added
http
|
LGTM if it works. Even if it doesn't work, nice to get those booleans out of there. |
|
LGTM |
|
Will also need to back out the ES6-isms and confirm that it fails on Node 0.10.20 and passes on Node 0.10.21. Should probably add a comment about that. |
|
Alas, the test passes in 0.10.20, albeit after a very, very, very long time. Time to tweak the test some more... |
|
Checking that Running new version through CI: https://ci.nodejs.org/job/node-test-pull-request/1358/ |
|
Raspberry Pi failure on CI, so that didn't do it either. |
|
Putting the socket timeout back to 200ms and re-running gives a pass: https://ci.nodejs.org/job/node-test-commit/1897/ Would like to run a stress test on Raspberry Pi to get a larger data set, though. |
|
Yep, LGTM if it works. |
|
Since the build team (Johan, I think) got Jenkins all snappy tonight, I'll try another CI run and HOPE FOR GREEN: https://ci.nodejs.org/job/node-test-pull-request/1390/ |
|
Here we go: https://ci.nodejs.org/job/node-test-pull-request/1395/ Green! \o/ |
Timer race results in some flakiness on slower devices in CI. Remove unneeded setTimeout() and replace booleans with common.mustCall(). PR-URL: nodejs#4793 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in cee14f5 |
Timer race results in some flakiness on slower devices in CI. Remove unneeded setTimeout() and replace booleans with common.mustCall(). PR-URL: #4793 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Timer race results in some flakiness on slower devices in CI. Remove unneeded setTimeout() and replace booleans with common.mustCall(). PR-URL: #4793 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Timer race results in some flakiness on slower devices in CI. Remove unneeded setTimeout() and replace booleans with common.mustCall(). PR-URL: #4793 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Timer race results in some flakiness on slower devices in CI. Remove unneeded setTimeout() and replace booleans with common.mustCall(). PR-URL: #4793 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Timer race results in some flakiness on slower devices in CI. Remove unneeded setTimeout() and replace booleans with common.mustCall(). PR-URL: #4793 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Timer race results in some flakiness on slower devices in CI. Remove unneeded setTimeout() and replace booleans with common.mustCall(). PR-URL: nodejs#4793 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Timer race results in some flakiness on slower devices in CI.