-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-api: add status napi_cannot_run_js #47986
Closed
gabrielschulhof
wants to merge
9
commits into
nodejs:main
from
gabrielschulhof:cannot-call-into-js-status
Closed
node-api: add status napi_cannot_run_js #47986
gabrielschulhof
wants to merge
9
commits into
nodejs:main
from
gabrielschulhof:cannot-call-into-js-status
Commits on May 13, 2023
-
node-api: add status napi_cannot_run_js
Add the new status in order to distinguish a state wherein an exception is pending from one wherein the engine is unable to execute JS. We take advantage of the new runtime add-on version reporting in order to remain forward compatible with add-ons that do not expect the new status code.
Configuration menu - View commit details
-
Copy full SHA for 0e89301 - Browse repository at this point
Copy the full SHA 0e89301View commit details
Commits on May 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 86277c9 - Browse repository at this point
Copy the full SHA 86277c9View commit details
Commits on May 18, 2023
-
Update test/node-api/test_cannot_run_js/test.js
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fa45e0a - Browse repository at this point
Copy the full SHA fa45e0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 95137f5 - Browse repository at this point
Copy the full SHA 95137f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72980e2 - Browse repository at this point
Copy the full SHA 72980e2View commit details
Commits on May 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d6f3232 - Browse repository at this point
Copy the full SHA d6f3232View commit details -
test: use variables instead of target_defaults
Some platforms do not seem to support target_defaults.
Configuration menu - View commit details
-
Copy full SHA for d8bee9e - Browse repository at this point
Copy the full SHA d8bee9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab54044 - Browse repository at this point
Copy the full SHA ab54044View commit details
Commits on May 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 128a6f8 - Browse repository at this point
Copy the full SHA 128a6f8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.