Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix parsing test flags #48012

Merged
merged 1 commit into from
May 17, 2023
Merged

test: fix parsing test flags #48012

merged 1 commit into from
May 17, 2023

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented May 15, 2023 •
edited
Loading

This does not replace _ with - when parsing flags.

I believe that it was added for a certain purpose, but it doesn't seem to be needed anymore. Currently, the cli options are not passed as intended in the following cases:

// Flags: --diagnostic-dir=~/PATH_HAS_UNDERSCORES
NOTE: The test started as a child_process using these flags: [ 
  '--diagnostic-dir=~/PATH-HAS-UNDERSCORES' <--
]
// Flags: --experimental-permission --allow-fs-read=~/PATH_HAS_UNDERSCORES
The test started as a child_process using these flags: [
  '--experimental-permission',
  '--allow-fs-read=~/PATH-HAS-UNDERSCORES'  <--
]

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

@daeyeon
test: fix parsing test flags
0c2e3a2 
This removes replacing `_` with `-` in the flags defined.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 15, 2023
MoLow
MoLow approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see any reasoning for this in the original PR adding this: #24876
and it matches the python behavior:

node/test/testpy/__init__.py

Lines 61 to 63 in a4e075f

flags_match = FLAGS_PATTERN.search(source)
if flags_match:
flags = flags_match.group(1).strip().split()

so LGTM

@daeyeon daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51810/

@github-actions github-actions bot mentioned this pull request May 16, 2023
Open
19 tasks
@daeyeon daeyeon added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 16, 2023
@github-actions github-actions bot mentioned this pull request May 17, 2023
Open
17 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 17, 2023
@nodejs-github-bot nodejs-github-bot merged commit 5cb5422 into nodejs:main May 17, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 5cb5422

This was referenced May 18, 2023
Open
Open
Open
Open
targos pushed a commit that referenced this pull request May 30, 2023
@daeyeon @targos
test: fix parsing test flags
a41cfd1 
This removes replacing `_` with `-` in the flags defined.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #48012
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jun 4, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@daeyeon @danielleadams
test: fix parsing test flags
bef81f4 
This removes replacing `_` with `-` in the flags defined.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #48012
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@daeyeon @MoLow
test: fix parsing test flags
ca4a0e3 
This removes replacing `_` with `-` in the flags defined.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: nodejs#48012
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daeyeon @nodejs-github-bot @lpinca @MoLow