Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix filename type in watch result #48032

Merged
merged 1 commit into from
Jun 23, 2023
Merged

doc: fix filename type in watch result #48032

merged 1 commit into from
Jun 23, 2023

Conversation

Semigradsky
Copy link
Contributor

By doc:

Providing filename argument in the callback is only supported on Linux,
macOS, Windows, and AIX. Even on supported platforms, filename is not always
guaranteed to be provided. Therefore, don't assume that filename argument is
always provided in the callback, and have some fallback logic if it is null.

So I added null to type to do it more clearly

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels May 16, 2023
@Semigradsky Semigradsky mentioned this pull request May 16, 2023
Merged
8 tasks
@sla100
Copy link
Contributor

sla100 commented May 28, 2023

Merged on @types/node

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 23, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 23, 2023
@nodejs-github-bot nodejs-github-bot merged commit 9b61322 into nodejs:main Jun 23, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 9b61322

RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@Semigradsky @RafaelGSS
doc: fix filename type in watch result
417927b 
PR-URL: #48032
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@Semigradsky @Ceres6
doc: fix filename type in watch result
28992e9 
PR-URL: nodejs#48032
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@Semigradsky @Ceres6
doc: fix filename type in watch result
f4beb65 
PR-URL: nodejs#48032
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 10, 2023
@Semigradsky @ruyadorno
doc: fix filename type in watch result
4a6c169 
PR-URL: #48032
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Sep 10, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@Semigradsky @ruyadorno
doc: fix filename type in watch result
e2f3ed1 
PR-URL: #48032
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@aymen94 aymen94 aymen94 approved these changes

@Mesteery Mesteery Mesteery approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Semigradsky @sla100 @nodejs-github-bot @jasnell @lpinca @aymen94 @Mesteery