Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: display dot report as wide as the terminal width #48038

Merged
merged 6 commits into from
May 23, 2023
Merged

test_runner: display dot report as wide as the terminal width #48038

merged 6 commits into from
May 23, 2023

Conversation

rluvaton
Copy link
Member

@rluvaton rluvaton commented May 16, 2023 •
edited
Loading

I had a problem with PR #47901 so recreating it

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 16, 2023
@rluvaton rluvaton mentioned this pull request May 16, 2023
Closed
@rluvaton @MoLow
Update lib/internal/test_runner/reporter/dot.js
ae1906c 
Co-authored-by: Moshe Atlow <moshe@atlow.co.il>
@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 19, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51876/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51878/

@github-actions github-actions bot mentioned this pull request May 20, 2023
Open
19 tasks
@rluvaton @aduh95
Update test/fixtures/test-runner/output/dot_output_custom_columns.js
b991fd2 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@github-actions github-actions bot mentioned this pull request May 21, 2023
Open
19 tasks
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label May 21, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 21, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51898/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51899/

cjihrig
cjihrig reviewed May 21, 2023
View reviewed changes
lib/internal/test_runner/reporter/dot.js
for await (const { type } of source) {
if (type === 'test:pass') {
yield '.';
}
if (type === 'test:fail') {
yield 'X';
}
if ((type === 'test:fail' || type === 'test:pass') && ++count % 20 === 0) {
if ((type === 'test:fail' || type === 'test:pass') && ++count === columns) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the ++count === columns be nested inside of the top level if? That way we only need to call getLineLength() once from there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The need to call again is in case of resize of the terminal

test/fixtures/test-runner/output/dot_output_custom_columns.js Outdated Show resolved Hide resolved
test/fixtures/test-runner/output/dot_output_custom_columns.js Outdated Show resolved Hide resolved
@github-actions github-actions bot mentioned this pull request May 22, 2023
Open
16 tasks
rluvaton and others added 2 commits May 22, 2023 07:56
@MoLow MoLow requested a review from cjihrig May 22, 2023 15:51
@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51917/

@github-actions github-actions bot mentioned this pull request May 23, 2023
Open
22 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51919/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2023
@nodejs-github-bot nodejs-github-bot merged commit 7e0c12f into nodejs:main May 23, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 7e0c12f

This was referenced May 24, 2023
Open
Open
Open
Open
Open
Open
Open
targos pushed a commit that referenced this pull request May 30, 2023
@rluvaton @targos
test_runner: display dot report as wide as the terminal width
23d310b 
PR-URL: #48038
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@github-actions github-actions bot mentioned this pull request May 31, 2023
Open
22 tasks
@targos targos mentioned this pull request Jun 4, 2023
Merged
@rluvaton rluvaton deleted the display-dot-test-report-as-wide-as-the-terminal branch June 28, 2023 17:40
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@rluvaton @danielleadams
test_runner: display dot report as wide as the terminal width
f8cf353 
PR-URL: #48038
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@rluvaton @MoLow
test_runner: display dot report as wide as the terminal width
e0d0b19 
PR-URL: nodejs#48038
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@rluvaton @Ceres6
test_runner: display dot report as wide as the terminal width
7af4903 
PR-URL: nodejs#48038
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@rluvaton @Ceres6
test_runner: display dot report as wide as the terminal width
ac4359d 
PR-URL: nodejs#48038
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 left review comments

@MoLow MoLow MoLow approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rluvaton @nodejs-github-bot @cjihrig @MoLow @aduh95