build: fix IBM i build with Python 3.9 #48056

richardlau · 2023-05-18T12:31:57Z

Python 3.9 on IBM i returns "os400" for sys.platform.

Refs: #46739
Refs: nodejs/build#3358

cc @nodejs/platform-ibmi

nodejs-github-bot · 2023-05-18T12:32:02Z

Review requested:

@nodejs/gyp

richardlau · 2023-05-18T12:32:36Z

IBM i CI: https://ci.nodejs.org/job/node-test-commit-ibmi/1163/

MoLow

Assuming build passes

mhdawson

LGTM

richardlau · 2023-05-18T20:51:10Z

Assuming build passes

Unfortunately it did not (after just shy of 8 hours)😞.

Errors look like this
https://ci.nodejs.org/job/node-test-commit-ibmi/1163/nodes=ibmi73-ppc64/consoleFull

20:51:27 Assembler:
20:51:27 /home/IOJS/build/cc49avPB.s: line 11: 1252-016 The specified opcode or pseudo-op is not valid.
20:51:27 	Use supported instructions or pseudo-ops only.
20:51:27 /home/IOJS/build/cc49avPB.s: line 12: 1252-016 The specified opcode or pseudo-op is not valid.
20:51:27 	Use supported instructions or pseudo-ops only.
...

I'm not 100% sure but it looks like this might be an intermediate/generated file during v8 (v8_snapshot?) -- the openssl bits that this PR was fixing were much earlier in the log. @abmusse Could you possibly take a look?

abmusse · 2023-05-18T22:02:19Z

Just took a peek at the log had scroll a bunch of The specified opcode or pseudo-op is not valid. like Richard noted above.

Looks like the command just before the first opcode error was:

15:51:26   ccache \
gcc-10 \
-o \
/home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi73-ppc64/out/Release/obj.target/v8_snapshot/geni/embedded.o \
/home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi73-ppc64/out/Release/obj.target/v8_snapshot/geni/embedded.S \
'-D_GLIBCXX_USE_CXX11_ABI=1' \
'-DNODE_OPENSSL_CONF_NAME=nodejs_conf' \
'-DNODE_OPENSSL_HAS_QUIC' \
'-DICU_NO_USER_DATA_OVERRIDE' \
'-DV8_GYP_BUILD' \
'-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64' \
'-D__STDC_FORMAT_MACROS' \
'-DOPENSSL_NO_PINSHARED' \
'-DOPENSSL_THREADS' \
'-DV8_TARGET_ARCH_PPC64' \
'-DV8_TARGET_ARCH_PPC_BE' \
'-D_LINUX_SOURCE_COMPAT=1' \
'-D_ALL_SOURCE=1' \
'-DV8_EMBEDDER_STRING="-node.9"' \
'-DENABLE_DISASSEMBLER' \
'-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' \
'-DOBJECT_PRINT' \
'-DV8_INTL_SUPPORT' \
'-DV8_ATOMIC_OBJECT_FIELD_WRITES' \
'-DV8_ENABLE_LAZY_SOURCE_POSITIONS' \
'-DV8_USE_SIPHASH' \
'-DV8_SHARED_RO_HEAP' \
'-DV8_WIN64_UNWINDING_INFO' \
'-DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH' \
'-DV8_USE_ZLIB' \
'-DV8_ENABLE_TURBOFAN' \
'-DV8_ENABLE_WEBASSEMBLY' \
'-DV8_ENABLE_JAVASCRIPT_PROMISE_HOOKS' \
'-DV8_ALLOCATION_FOLDING' \
'-DV8_ALLOCATION_SITE_TRACKING' \
'-DV8_SCRIPTORMODULE_LEGACY_LIFETIME' \
'-DV8_ADVANCED_BIGINT_ALGORITHMS' \
'-DUCONFIG_NO_SERVICE=1' \
'-DU_ENABLE_DYLOAD=0' \
'-DU_STATIC_IMPLEMENTATION=1' \
'-DU_HAVE_STD_STRING=1' \
'-DUCONFIG_NO_BREAK_ITERATION=0' \
-I../deps/v8 \
-I../deps/v8/include \
-I/home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi73-ppc64/out/Release/obj/gen/generate-bytecode-output-root \
-I/home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi73-ppc64/out/Release/obj/gen \
-I../deps/icu-small/source/i18n \
-I../deps/icu-small/source/common \
-pthread \
-Wno-unused-parameter \
-maix64 \
-Wno-return-type \
-ffp-contract=off \
-mcpu=power5+ \
-mfprnd \
-mno-popcntb \
-fno-strict-aliasing \
-maix64 \
-fdollars-in-identifiers \
-fno-extern-tls-init \
-O3 \
-fno-omit-frame-pointer \
-fdata-sections \
-ffunction-sections \
-O3 \
-MMD \
-MF \
/home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi73-ppc64/out/Release/.deps//home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi73-ppc64/out/Release/obj.target/v8_snapshot/geni/embedded.o.d.raw \
-c

19:51:42 gmake[2]: *** [Makefile:272: /home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi73-ppc64/out/Release/obj.target/v8_snapshot/geni/embedded.o] Error 1

abmusse · 2023-05-18T22:11:21Z

@richardlau

Does v8 link with openssl? I'm not sure how your changes to the embedded openssl results in v8 compile failure.

FYI for our IBM i releases of node we build with --shared-openssl and link with our release openssl3.
When using --shared-openssl do we need these changes to the embedded openssl?

Is it possible for us to do the same in the CI, i.e. Install our openssl3 and build with --shared-openssl?

richardlau · 2023-05-19T00:40:46Z

@richardlau

Does v8 link with openssl? I'm not sure how your changes to the embedded openssl results in v8 compile failure.

FYI for our IBM i releases of node we build with --shared-openssl and link with our release openssl3. When using --shared-openssl do we need these changes to the embedded openssl?

Is it possible for us to do the same in the CI, i.e. Install our openssl3 and build with --shared-openssl?

I tried passing --shared-openssl in CONFIG_FLAGS in https://ci.nodejs.org/job/node-test-commit-ibmi/1164/ and we still have the same failures. From https://ci.nodejs.org/job/node-test-commit-ibmi/1164/nodes=ibmi73-ppc64/consoleFull you can see it has set:

23:13:27 { 'target_defaults': { 'cflags': [],
23:13:27                        'default_configuration': 'Release',
23:13:27                        'defines': [ 'NODE_OPENSSL_CONF_NAME=nodejs_conf',
23:13:27                                     'ICU_NO_USER_DATA_OVERRIDE'],
23:13:27                        'include_dirs': ['/QOpenSys/pkgs/include'],
23:13:27                        'libraries': [ '-L/QOpenSys/pkgs/lib',
23:13:27                                       '-lcrypto',
23:13:27                                       '-lssl']},
...
23:13:31                  'node_shared_openssl': 'true',

That run was on main, without the changes in this PR. My suspicion is that something isn't being set correctly now that we are using Python 3.9.

abmusse · 2023-05-19T01:42:28Z

Ah yes, I suspect we still need these changes:

https://chromium-review.googlesource.com/c/v8/v8/+/4259330

This is the only patch we apply in our Node 20 build as v8 has not merged this yet.

Should we make a PR with these changes?

richardlau · 2023-05-19T11:31:09Z

Ah yes, I suspect we still need these changes:

https://chromium-review.googlesource.com/c/v8/v8/+/4259330

This is the only patch we apply in our Node 20 build as v8 has not merged this yet.

Should we make a PR with these changes?

We generally avoid floating patches on top of V8 as it complicates updating V8 versions in Node.js. We need to get https://chromium-review.googlesource.com/c/v8/v8/+/4259330 merged upstream in V8 first and then we can cherry-pick or update V8 in Node.js. Perhaps @miladfarca could help advise how to get that CL merged into V8.

Refs: https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-V8.md

In the meantime I'll make node-test-commit-ibmi run with Python 3.6 until we have the V8 patch merged.

miladfarca · 2023-05-19T14:19:58Z

We generally avoid floating patches on top of V8 as it complicates updating V8 versions in Node.js. We need to get https://chromium-review.googlesource.com/c/v8/v8/+/4259330 merged upstream in V8 first and then we can cherry-pick or update V8 in Node.js. Perhaps @miladfarca could help advise how to get that CL merged into V8.

If contributing for the first time make sure you have signed a CLA: https://v8.dev/docs/contribute#sign-the-cla
To start the review process click on Reply > Suggest Owners and choose form the list. Above changes could have verwaest and machenbach as reviewers.

kadler · 2023-08-01T17:40:51Z

Since Meng Xu is no longer working on IBM i, I think we'll have to take over his PR. @abmusse let's work on getting you set up to take the upstream PR over.

abmusse · 2023-08-17T21:01:22Z

We generally avoid floating patches on top of V8 as it complicates updating V8 versions in Node.js. We need to get https://chromium-review.googlesource.com/c/v8/v8/+/4259330 merged upstream in V8 first and then we can cherry-pick or update V8 in Node.js. Perhaps @miladfarca could help advise how to get that CL merged into V8.

If contributing for the first time make sure you have signed a CLA: https://v8.dev/docs/contribute#sign-the-cla To start the review process click on Reply > Suggest Owners and choose form the list. Above changes could have verwaest and machenbach as reviewers.

@miladfarca

I've gained approval to contribute to v8 through the IBM process. Should be good with signing the CLA.
I've added verwaest and machenbach as reviewers as you suggested and commented on the PR.
Hopefully we can get the ball rolling on the next steps with moving forward with the PR!

abmusse · 2023-09-06T17:09:40Z

Got setup and created a CL with the minimal amount of changes needed

https://chromium-review.googlesource.com/c/v8/v8/+/4846413

miladfarca · 2023-09-06T17:14:09Z

@abmusse Click on "Reply > Suggest Owners > show all owners" and select at least one owner to review your CL.

abmusse · 2023-09-06T17:22:43Z

@abmusse Click on "Reply > Suggest Owners > show all owners" and select at least one owner to review your CL.

Thanks, I've added the reviewers!

abmusse · 2023-09-14T16:51:54Z

Got setup and created a CL with the minimal amount of changes needed

https://chromium-review.googlesource.com/c/v8/v8/+/4846413

CC @richardlau

UPDATE:

The above CL got merged 🎉

richardlau · 2023-09-15T14:45:49Z

Got setup and created a CL with the minimal amount of changes needed
https://chromium-review.googlesource.com/c/v8/v8/+/4846413

CC @richardlau

UPDATE:

The above CL got merged 🎉

@abmusse Could you open a V8 backport PR?
See https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-V8.md#backporting-to-abandoned-branches

abmusse · 2023-09-25T16:49:26Z

Got setup and created a CL with the minimal amount of changes needed
https://chromium-review.googlesource.com/c/v8/v8/+/4846413

CC @richardlau
UPDATE:
The above CL got merged 🎉

@abmusse Could you open a V8 backport PR? See https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-V8.md#backporting-to-abandoned-branches

Opened backport PR: #49862

When built with Python 3.9 on IBM i, `process.platform` will return `os400` instead of `aix`. In preparation for this, make `common.isAIX` only return true for AIX and update the tests to add checks for `common.isIBMi` where they were missing. PR-URL: nodejs#48056 Refs: nodejs#46739 Refs: nodejs/build#3358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Python 3.9 on IBM i returns "os400" for `sys.platform`. PR-URL: nodejs#48056 Refs: nodejs#46739 Refs: nodejs/build#3358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Original commit message: fix: EmbeddedTargetOs on IBM i with Python 3.9 For some context, Python 3.9 on IBM i returns "os400" for sys.platform instead of "aix". We used to build with Python 3.6 which returned "aix" as the platform When attempting to build Node.js with python 3.9 on IBM i we run into a build error. Ref: nodejs#48056 Ref: nodejs#48056 (comment) I'm not quite sure where target_os is being passed down to the function ToEmbeddedTargetOs. It seems as though target_os is being generated from sys.platform or similar call from python as we started running into this issue after building with Python 3.9. This PR supersedes initial changes proposed in: https://chromium-review.googlesource.com/c/v8/v8/+/4259330 This PR contains the minimal changes to successfully build Node.js (builds v8 as an internal dep) on IBM i with Python 3.9. Change-Id: I32d43197bce994a72a0d85091e91f80eeea4482d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4846413 Commit-Queue: Jakob Linke <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#89981} Refs: v8/v8@8ec2651

Original commit message: fix: EmbeddedTargetOs on IBM i with Python 3.9 For some context, Python 3.9 on IBM i returns "os400" for sys.platform instead of "aix". We used to build with Python 3.6 which returned "aix" as the platform When attempting to build Node.js with python 3.9 on IBM i we run into a build error. Ref: #48056 Ref: #48056 (comment) I'm not quite sure where target_os is being passed down to the function ToEmbeddedTargetOs. It seems as though target_os is being generated from sys.platform or similar call from python as we started running into this issue after building with Python 3.9. This PR supersedes initial changes proposed in: https://chromium-review.googlesource.com/c/v8/v8/+/4259330 This PR contains the minimal changes to successfully build Node.js (builds v8 as an internal dep) on IBM i with Python 3.9. Change-Id: I32d43197bce994a72a0d85091e91f80eeea4482d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4846413 Commit-Queue: Jakob Linke <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#89981} Refs: v8/v8@8ec2651 PR-URL: #49639 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

When built with Python 3.9 on IBM i, `process.platform` will return `os400` instead of `aix`. In preparation for this, make `common.isAIX` only return true for AIX and update the tests to add checks for `common.isIBMi` where they were missing. PR-URL: #48056 Refs: #46739 Refs: nodejs/build#3358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Python 3.9 on IBM i returns "os400" for `sys.platform`. PR-URL: #48056 Refs: #46739 Refs: nodejs/build#3358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Original commit message: fix: EmbeddedTargetOs on IBM i with Python 3.9 For some context, Python 3.9 on IBM i returns "os400" for sys.platform instead of "aix". We used to build with Python 3.6 which returned "aix" as the platform When attempting to build Node.js with python 3.9 on IBM i we run into a build error. Ref: nodejs#48056 Ref: nodejs#48056 (comment) I'm not quite sure where target_os is being passed down to the function ToEmbeddedTargetOs. It seems as though target_os is being generated from sys.platform or similar call from python as we started running into this issue after building with Python 3.9. This PR supersedes initial changes proposed in: https://chromium-review.googlesource.com/c/v8/v8/+/4259330 This PR contains the minimal changes to successfully build Node.js (builds v8 as an internal dep) on IBM i with Python 3.9. Change-Id: I32d43197bce994a72a0d85091e91f80eeea4482d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4846413 Commit-Queue: Jakob Linke <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#89981} Refs: v8/v8@8ec2651 PR-URL: nodejs#49862 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

When built with Python 3.9 on IBM i, `process.platform` will return `os400` instead of `aix`. In preparation for this, make `common.isAIX` only return true for AIX and update the tests to add checks for `common.isIBMi` where they were missing. PR-URL: nodejs#48056 Refs: nodejs#46739 Refs: nodejs/build#3358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Python 3.9 on IBM i returns "os400" for `sys.platform`. PR-URL: nodejs#48056 Refs: nodejs#46739 Refs: nodejs/build#3358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Original commit message: fix: EmbeddedTargetOs on IBM i with Python 3.9 For some context, Python 3.9 on IBM i returns "os400" for sys.platform instead of "aix". We used to build with Python 3.6 which returned "aix" as the platform When attempting to build Node.js with python 3.9 on IBM i we run into a build error. Ref: nodejs#48056 Ref: nodejs#48056 (comment) I'm not quite sure where target_os is being passed down to the function ToEmbeddedTargetOs. It seems as though target_os is being generated from sys.platform or similar call from python as we started running into this issue after building with Python 3.9. This PR supersedes initial changes proposed in: https://chromium-review.googlesource.com/c/v8/v8/+/4259330 This PR contains the minimal changes to successfully build Node.js (builds v8 as an internal dep) on IBM i with Python 3.9. Change-Id: I32d43197bce994a72a0d85091e91f80eeea4482d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4846413 Commit-Queue: Jakob Linke <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#89981} Refs: v8/v8@8ec2651 PR-URL: nodejs#49639 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Original commit message: fix: EmbeddedTargetOs on IBM i with Python 3.9 For some context, Python 3.9 on IBM i returns "os400" for sys.platform instead of "aix". We used to build with Python 3.6 which returned "aix" as the platform When attempting to build Node.js with python 3.9 on IBM i we run into a build error. Ref: #48056 Ref: #48056 (comment) I'm not quite sure where target_os is being passed down to the function ToEmbeddedTargetOs. It seems as though target_os is being generated from sys.platform or similar call from python as we started running into this issue after building with Python 3.9. This PR supersedes initial changes proposed in: https://chromium-review.googlesource.com/c/v8/v8/+/4259330 This PR contains the minimal changes to successfully build Node.js (builds v8 as an internal dep) on IBM i with Python 3.9. Change-Id: I32d43197bce994a72a0d85091e91f80eeea4482d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4846413 Commit-Queue: Jakob Linke <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#89981} Refs: v8/v8@8ec2651 PR-URL: #49862 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

When built with Python 3.9 on IBM i, `process.platform` will return `os400` instead of `aix`. In preparation for this, make `common.isAIX` only return true for AIX and update the tests to add checks for `common.isIBMi` where they were missing. PR-URL: #48056 Refs: #46739 Refs: nodejs/build#3358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Python 3.9 on IBM i returns "os400" for `sys.platform`. PR-URL: #48056 Refs: #46739 Refs: nodejs/build#3358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Original commit message: fix: EmbeddedTargetOs on IBM i with Python 3.9 For some context, Python 3.9 on IBM i returns "os400" for sys.platform instead of "aix". We used to build with Python 3.6 which returned "aix" as the platform When attempting to build Node.js with python 3.9 on IBM i we run into a build error. Ref: nodejs#48056 Ref: nodejs#48056 (comment) I'm not quite sure where target_os is being passed down to the function ToEmbeddedTargetOs. It seems as though target_os is being generated from sys.platform or similar call from python as we started running into this issue after building with Python 3.9. This PR supersedes initial changes proposed in: https://chromium-review.googlesource.com/c/v8/v8/+/4259330 This PR contains the minimal changes to successfully build Node.js (builds v8 as an internal dep) on IBM i with Python 3.9. Change-Id: I32d43197bce994a72a0d85091e91f80eeea4482d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4846413 Commit-Queue: Jakob Linke <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#89981} Refs: v8/v8@8ec2651 PR-URL: nodejs#49862 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

When built with Python 3.9 on IBM i, `process.platform` will return `os400` instead of `aix`. In preparation for this, make `common.isAIX` only return true for AIX and update the tests to add checks for `common.isIBMi` where they were missing. PR-URL: nodejs#48056 Refs: nodejs#46739 Refs: nodejs/build#3358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Python 3.9 on IBM i returns "os400" for `sys.platform`. PR-URL: nodejs#48056 Refs: nodejs#46739 Refs: nodejs/build#3358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Original commit message: fix: EmbeddedTargetOs on IBM i with Python 3.9 For some context, Python 3.9 on IBM i returns "os400" for sys.platform instead of "aix". We used to build with Python 3.6 which returned "aix" as the platform When attempting to build Node.js with python 3.9 on IBM i we run into a build error. Ref: nodejs#48056 Ref: nodejs#48056 (comment) I'm not quite sure where target_os is being passed down to the function ToEmbeddedTargetOs. It seems as though target_os is being generated from sys.platform or similar call from python as we started running into this issue after building with Python 3.9. This PR supersedes initial changes proposed in: https://chromium-review.googlesource.com/c/v8/v8/+/4259330 This PR contains the minimal changes to successfully build Node.js (builds v8 as an internal dep) on IBM i with Python 3.9. Change-Id: I32d43197bce994a72a0d85091e91f80eeea4482d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4846413 Commit-Queue: Jakob Linke <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#89981} Refs: v8/v8@8ec2651 PR-URL: nodejs#49639 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

When built with Python 3.9 on IBM i, `process.platform` will return `os400` instead of `aix`. In preparation for this, make `common.isAIX` only return true for AIX and update the tests to add checks for `common.isIBMi` where they were missing. PR-URL: nodejs/node#48056 Refs: nodejs/node#46739 Refs: nodejs/build#3358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Python 3.9 on IBM i returns "os400" for `sys.platform`. PR-URL: nodejs/node#48056 Refs: nodejs/node#46739 Refs: nodejs/build#3358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

When built with Python 3.9 on IBM i, `process.platform` will return `os400` instead of `aix`. In preparation for this, make `common.isAIX` only return true for AIX and update the tests to add checks for `common.isIBMi` where they were missing. PR-URL: nodejs/node#48056 Refs: nodejs/node#46739 Refs: nodejs/build#3358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Python 3.9 on IBM i returns "os400" for `sys.platform`. PR-URL: nodejs/node#48056 Refs: nodejs/node#46739 Refs: nodejs/build#3358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

richardlau added the ibm i Issues and PRs related to the IBM i platform. label May 18, 2023

nodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. labels May 18, 2023

MoLow approved these changes May 18, 2023

View reviewed changes

richardlau mentioned this pull request May 18, 2023

ansible: updates for IBM i nodejs/build#3358

Merged

mhdawson approved these changes May 18, 2023

View reviewed changes

lpinca approved these changes May 19, 2023

View reviewed changes

abmusse mentioned this pull request Jul 31, 2023

test: parallel.test-module-loading-error fails on IBM i #48980

Closed

UlisesGascon approved these changes Sep 15, 2023

View reviewed changes

richardlau added the blocked PRs that are blocked by other issues or PRs. label Sep 15, 2023

MoLow approved these changes Sep 17, 2023

View reviewed changes

This was referenced Sep 30, 2023

CI Reliability 2023-09-30 nodejs/reliability#679

Open

CI Reliability 2023-10-01 nodejs/reliability#680

Open

github-actions bot mentioned this pull request Oct 2, 2023

CI Reliability 2023-10-02 nodejs/reliability#681

Open

12 tasks

RafaelGSS mentioned this pull request Oct 9, 2023

2023-10-17, Version 21.0.0 (Current) #49870

Merged

targos mentioned this pull request Nov 12, 2023

v20.10.0 release proposal #50682

Merged

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

juanarbol mentioned this pull request Dec 6, 2023

2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: fix IBM i build with Python 3.9 #48056

build: fix IBM i build with Python 3.9 #48056

richardlau commented May 18, 2023

nodejs-github-bot commented May 18, 2023

richardlau commented May 18, 2023

MoLow left a comment

mhdawson left a comment

richardlau commented May 18, 2023

abmusse commented May 18, 2023 •

edited

Loading

abmusse commented May 18, 2023 •

edited

Loading

richardlau commented May 19, 2023 •

edited

Loading

abmusse commented May 19, 2023 •

edited

Loading

richardlau commented May 19, 2023

miladfarca commented May 19, 2023

kadler commented Aug 1, 2023

abmusse commented Aug 17, 2023 •

edited

Loading

abmusse commented Sep 6, 2023

miladfarca commented Sep 6, 2023 •

edited

Loading

abmusse commented Sep 6, 2023

abmusse commented Sep 14, 2023 •

edited

Loading

richardlau commented Sep 15, 2023

abmusse commented Sep 25, 2023

build: fix IBM i build with Python 3.9 #48056

build: fix IBM i build with Python 3.9 #48056

Conversation

richardlau commented May 18, 2023

nodejs-github-bot commented May 18, 2023

richardlau commented May 18, 2023

MoLow left a comment

Choose a reason for hiding this comment

mhdawson left a comment

Choose a reason for hiding this comment

richardlau commented May 18, 2023

abmusse commented May 18, 2023 • edited Loading

abmusse commented May 18, 2023 • edited Loading

richardlau commented May 19, 2023 • edited Loading

abmusse commented May 19, 2023 • edited Loading

richardlau commented May 19, 2023

miladfarca commented May 19, 2023

kadler commented Aug 1, 2023

abmusse commented Aug 17, 2023 • edited Loading

abmusse commented Sep 6, 2023

miladfarca commented Sep 6, 2023 • edited Loading

abmusse commented Sep 6, 2023

abmusse commented Sep 14, 2023 • edited Loading

richardlau commented Sep 15, 2023

abmusse commented Sep 25, 2023

abmusse commented May 18, 2023 •

edited

Loading

abmusse commented May 18, 2023 •

edited

Loading

richardlau commented May 19, 2023 •

edited

Loading

abmusse commented May 19, 2023 •

edited

Loading

abmusse commented Aug 17, 2023 •

edited

Loading

miladfarca commented Sep 6, 2023 •

edited

Loading

abmusse commented Sep 14, 2023 •

edited

Loading