Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-tick-processor flaky #4809

Closed
wants to merge 1 commit into from
Closed

test: mark test-tick-processor flaky #4809

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 21, 2016

Ref: #4427

Recent sample failures:

@Trott Trott added v8 engine Issues and PRs related to the V8 dependency. test Issues and PRs related to the tests. labels Jan 21, 2016
@jasnell
Copy link
Member

jasnell commented Jan 22, 2016

@Trott ... is this flakiness due to recent changes or would this need to be marked in LTS also?

@Trott
Copy link
Member Author

Trott commented Jan 22, 2016

@jasnell This should apply to LTS as well.

@Trott
Copy link
Member Author

Trott commented Jan 24, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/1360/

/cc @nodejs/testing (looking for an LGTM on this, seems like it should be non-controversial)

@jasnell
Copy link
Member

jasnell commented Jan 24, 2016

LGTM
On Jan 23, 2016 11:35 PM, "Rich Trott" notifications@github.com wrote:

CI: https://ci.nodejs.org/job/node-test-pull-request/1360/

/cc @nodejs/testing https://github.com/orgs/nodejs/teams/testing
(looking for an LGTM on this, seems like it should be non-controversial)

—
Reply to this email directly or view it on GitHub
#4809 (comment).

@jbergstroem
Copy link
Member

LGTM 😢

@cjihrig
Copy link
Contributor

cjihrig commented Jan 24, 2016

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Jan 25, 2016
@Trott
test: mark test-tick-processor flaky
c6d29cb 
PR-URL: nodejs#4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#4427
@Trott
Copy link
Member Author

Trott commented Jan 25, 2016

Landed in c6d29cb

@Trott Trott closed this Jan 25, 2016
rvagg pushed a commit that referenced this pull request Jan 25, 2016
@Trott @rvagg
test: mark test-tick-processor flaky
ae9a8cd 
PR-URL: #4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: #4427
benjamingr pushed a commit to benjamingr/io.js that referenced this pull request Jan 27, 2016
@Trott @benjamingr
test: mark test-tick-processor flaky
0e16694 
PR-URL: nodejs#4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#4427
@jasnell
Copy link
Member

jasnell commented Jan 27, 2016

@Trott .. I marked this lts-watch for v4.. can you confirm that tho? Not sure when this went flaky

@Trott
Copy link
Member Author

Trott commented Jan 28, 2016

@jasnell I ran a stress test against the v4.x branch and the test is flaky there, so yes, confirmed. https://ci.nodejs.org/job/node-stress-single-test/377/nodes=win2008r2/console

@rvagg rvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
@Trott
test: mark test-tick-processor flaky
78449b6 
PR-URL: #4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: #4427
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
@Trott
test: mark test-tick-processor flaky
0a44e6a 
PR-URL: #4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: #4427
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@Trott
test: mark test-tick-processor flaky
183bdef 
PR-URL: #4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: #4427
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Trott
test: mark test-tick-processor flaky
3e1caee 
PR-URL: nodejs#4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#4427
@Trott Trott deleted the mark-test-tick-processor branch January 13, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @jasnell @jbergstroem @cjihrig @MylesBorins