-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update c-ares to 1.19.1 #48115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
dependencies
Pull requests that update a dependency file.
label
May 22, 2023
Review requested:
|
nodejs-github-bot
added
cares
Issues and PRs related to the c-ares dependency or the cares_wrap binding.
needs-ci
PRs that need a full CI run.
labels
May 22, 2023
There are new files. We probably need to update the .gyp file. |
targos
approved these changes
May 22, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
May 22, 2023
RafaelGSS
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Trott
added
the
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
label
May 22, 2023
Trott
approved these changes
May 22, 2023
Trott
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
May 22, 2023
This was referenced May 23, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
May 24, 2023
Landed in 21153a8 |
richardlau
added
lts-watch-v16.x
lts-watch-v18.x
PRs that may need to be released in v18.x.
labels
May 24, 2023
This was referenced May 25, 2023
23 tasks
targos
pushed a commit
that referenced
this pull request
May 30, 2023
PR-URL: #48115 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
22 tasks
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 22, 2023
denihs
pushed a commit
to meteor/node-v14-esm
that referenced
this pull request
Jun 22, 2023
PR-URL: nodejs#48115 Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/437 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> # Conflicts: # deps/cares/CHANGES # deps/cares/CMakeLists.txt # deps/cares/RELEASE-NOTES # deps/cares/aminclude_static.am # deps/cares/configure # deps/cares/configure.ac # deps/cares/include/ares_version.h # deps/cares/src/lib/Makefile.in # deps/cares/src/lib/ares_data.h # deps/cares/src/lib/ares_destroy.c # deps/cares/src/lib/ares_getaddrinfo.c # deps/cares/src/lib/ares_init.c # deps/cares/src/lib/ares_strsplit.c
denihs
pushed a commit
to meteor/node-v14-esm
that referenced
this pull request
Jun 23, 2023
PR-URL: nodejs#48115 Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/437 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> # Conflicts: # deps/cares/CHANGES # deps/cares/CMakeLists.txt # deps/cares/RELEASE-NOTES # deps/cares/aminclude_static.am # deps/cares/configure # deps/cares/configure.ac # deps/cares/include/ares_version.h # deps/cares/src/lib/Makefile.in # deps/cares/src/lib/ares_data.h # deps/cares/src/lib/ares_destroy.c # deps/cares/src/lib/ares_getaddrinfo.c # deps/cares/src/lib/ares_init.c # deps/cares/src/lib/ares_strsplit.c
erikolofsson
pushed a commit
to Malterlib/node
that referenced
this pull request
Jun 26, 2023
PR-URL: nodejs#48115 Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/437 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
erikolofsson
pushed a commit
to Malterlib/node
that referenced
this pull request
Jun 26, 2023
PR-URL: nodejs#48115 Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/437 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
jkleinsc
pushed a commit
to electron/electron
that referenced
this pull request
Jun 26, 2023
* chore: bump node in DEPS to v18.16.1 * chore: update patches * deps: update c-ares to 1.19.1 nodejs/node#48115 * chore: fix -Wunreachable-code,-Werror FTBFS in c-ares * chore: disable x509 bssl test new test added in bf3e2c892 * fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares also fix related -Werror,-Wunused-function FTBFS * fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares also fix another related -Werror,-Wunused-function FTBFS * fixup! chore: disable x509 bssl test fix yet another -Werror,-Wunused-function FTBFS --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
denihs
pushed a commit
to meteor/node-v14-esm
that referenced
this pull request
Jul 3, 2023
PR-URL: nodejs#48115 Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/437 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> # Conflicts: # deps/cares/CHANGES # deps/cares/CMakeLists.txt # deps/cares/RELEASE-NOTES # deps/cares/aminclude_static.am # deps/cares/configure # deps/cares/configure.ac # deps/cares/include/ares_version.h # deps/cares/src/lib/Makefile.in # deps/cares/src/lib/ares_data.h # deps/cares/src/lib/ares_destroy.c # deps/cares/src/lib/ares_getaddrinfo.c # deps/cares/src/lib/ares_init.c # deps/cares/src/lib/ares_strsplit.c
denihs
pushed a commit
to meteor/node-v14-esm
that referenced
this pull request
Jul 3, 2023
PR-URL: nodejs#48115 Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/437 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
baparham
pushed a commit
to baparham/electron
that referenced
this pull request
Jul 12, 2023
* chore: bump node in DEPS to v18.16.1 * chore: update patches * deps: update c-ares to 1.19.1 nodejs/node#48115 * chore: fix -Wunreachable-code,-Werror FTBFS in c-ares * chore: disable x509 bssl test new test added in bf3e2c892 * fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares also fix related -Werror,-Wunused-function FTBFS * fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares also fix another related -Werror,-Wunused-function FTBFS * fixup! chore: disable x509 bssl test fix yet another -Werror,-Wunused-function FTBFS --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jul 20, 2023
chore: bump node to v18.16.1 (main) (#38869) * chore: bump node in DEPS to v18.16.1 * chore: update patches * deps: update c-ares to 1.19.1 nodejs/node#48115 * chore: fix -Wunreachable-code,-Werror FTBFS in c-ares * chore: disable x509 bssl test new test added in bf3e2c892 * fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares also fix related -Werror,-Wunused-function FTBFS * fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares also fix another related -Werror,-Wunused-function FTBFS * fixup! chore: disable x509 bssl test fix yet another -Werror,-Wunused-function FTBFS --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48115 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48115 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau
added
backported-to-v16.x
backported-to-v18.x
PRs backported to the v18.x-staging branch.
and removed
lts-watch-v16.x
lts-watch-v18.x
PRs that may need to be released in v18.x.
labels
Aug 24, 2023
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
* chore: bump node in DEPS to v18.16.1 * chore: update patches * deps: update c-ares to 1.19.1 nodejs/node#48115 * chore: fix -Wunreachable-code,-Werror FTBFS in c-ares * chore: disable x509 bssl test new test added in bf3e2c892 * fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares also fix related -Werror,-Wunused-function FTBFS * fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares also fix another related -Werror,-Wunused-function FTBFS * fixup! chore: disable x509 bssl test fix yet another -Werror,-Wunused-function FTBFS --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backported-to-v18.x
PRs backported to the v18.x-staging branch.
cares
Issues and PRs related to the c-ares dependency or the cares_wrap binding.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
dependencies
Pull requests that update a dependency file.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated update of c-ares to 1.19.1.