stream: refactor redeclared variables #4816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`lib/_stream_readable.js` contained three instances of `var` declarations occurring twice in the same scope. Refactored to `const` or `let` as appropriate.
Trott
added
stream
|
LGTM |
1 similar comment
|
LGTM |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 25, 2016
`lib/_stream_readable.js` contained three instances of `var` declarations occurring twice in the same scope. Refactored to `const` or `let` as appropriate. PR-URL: nodejs#4816 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 06a5072 |
rvagg
pushed a commit
that referenced
this pull request
Jan 25, 2016
`lib/_stream_readable.js` contained three instances of `var` declarations occurring twice in the same scope. Refactored to `const` or `let` as appropriate. PR-URL: #4816 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
benjamingr
pushed a commit
to benjamingr/io.js
that referenced
this pull request
Jan 27, 2016
`lib/_stream_readable.js` contained three instances of `var` declarations occurring twice in the same scope. Refactored to `const` or `let` as appropriate. PR-URL: nodejs#4816 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 17, 2016
`lib/_stream_readable.js` contained three instances of `var` declarations occurring twice in the same scope. Refactored to `const` or `let` as appropriate. PR-URL: #4816 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
`lib/_stream_readable.js` contained three instances of `var` declarations occurring twice in the same scope. Refactored to `const` or `let` as appropriate. PR-URL: #4816 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
`lib/_stream_readable.js` contained three instances of `var` declarations occurring twice in the same scope. Refactored to `const` or `let` as appropriate. PR-URL: #4816 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
`lib/_stream_readable.js` contained three instances of `var` declarations occurring twice in the same scope. Refactored to `const` or `let` as appropriate. PR-URL: nodejs#4816 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Oct 18, 2022
This was referenced Oct 18, 2022
This was referenced Oct 18, 2022
This was referenced Oct 19, 2022
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/_stream_readable.jscontained three instances ofvardeclarations occurring twice in the same scope. Refactored to
constorletas appropriate.