Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: order dependency jobs alphabetically #48184

Merged

Conversation

lutaok
Copy link
Contributor

@lutaok lutaok commented May 26, 2023

Hi everyone,
I opened this PR to tackle the last bullet point of this issue where jobs in tools.yml were not ordered alphabetically.

I also added the following options in workflow_dispatch, that were missing:

  • minimatch
  • zlib

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 26, 2023
@marco-ippolito marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 26, 2023
@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/48184
✔  Done loading data for nodejs/node/pull/48184
----------------------------------- PR info ------------------------------------
Title      tools: order dependency jobs alphabetically (#48184)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     lutaok:jobs-dependencies-alphabetic-order -> nodejs:main
Labels     meta, author ready
Commits    3
 - tools: order dependency jobs alphabetically
 - tools: add missing dependencies options
 - tools: Revert spacing before comments
Committers 1
 - lutaok 
PR-URL: https://github.com/nodejs/node/pull/48184
Reviewed-By: Marco Ippolito 
Reviewed-By: Mestery 
Reviewed-By: Luigi Pinca 
Reviewed-By: Debadree Chatterjee 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48184
Reviewed-By: Marco Ippolito 
Reviewed-By: Mestery 
Reviewed-By: Luigi Pinca 
Reviewed-By: Debadree Chatterjee 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 26 May 2023 07:01:21 GMT
   ✔  Approvals: 4
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/48184#pullrequestreview-1446499944
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/48184#pullrequestreview-1446788888
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48184#pullrequestreview-1447507295
   ✔  - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/48184#pullrequestreview-1448806651
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   023e8803f8..b47fce0762  main       -> origin/main
✔  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - 2b236c8e70 test_runner: remove redundant check from coverage
 - b47fce0762 test_runner: remove redundant check from coverage
--------------------------------------------------------------------------------
HEAD is now at b47fce0762 test_runner: remove redundant check from coverage
   ✔  Reset to origin/main
- Downloading patch for 48184
From https://github.com/nodejs/node
 * branch                  refs/pull/48184/merge -> FETCH_HEAD
✔  Fetched commits as b47fce07620a..3be7024073da
--------------------------------------------------------------------------------
[main adeba4d8f0] tools: order dependency jobs alphabetically
 Author: lutaok 
 Date: Fri May 26 08:49:48 2023 +0200
 1 file changed, 98 insertions(+), 98 deletions(-)
[main 84200f7809] tools: add missing dependencies options
 Author: lutaok 
 Date: Fri May 26 08:58:16 2023 +0200
 1 file changed, 2 insertions(+)
[main 6d043268e8] tools: Revert spacing before comments
 Author: lutaok 
 Date: Fri May 26 13:36:31 2023 +0200
 1 file changed, 5 insertions(+), 5 deletions(-)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
Rebasing (2/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: order dependency jobs alphabetically

Refs: nodejs/security-wg#973
PR-URL: #48184
Reviewed-By: Marco Ippolito marcoippolito54@gmail.com
Reviewed-By: Mestery mestery@protonmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Debadree Chatterjee debadree333@gmail.com

[detached HEAD 7878c7a36a] tools: order dependency jobs alphabetically
Author: lutaok lucadig.1994@gmail.com
Date: Fri May 26 08:49:48 2023 +0200
1 file changed, 98 insertions(+), 98 deletions(-)
Rebasing (3/6)
Rebasing (4/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: add missing dependencies options

Refs: nodejs/security-wg#973
PR-URL: #48184
Reviewed-By: Marco Ippolito marcoippolito54@gmail.com
Reviewed-By: Mestery mestery@protonmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Debadree Chatterjee debadree333@gmail.com

[detached HEAD 63f1af6236] tools: add missing dependencies options
Author: lutaok lucadig.1994@gmail.com
Date: Fri May 26 08:58:16 2023 +0200
1 file changed, 2 insertions(+)
Rebasing (5/6)
Rebasing (6/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: Revert spacing before comments

PR-URL: #48184
Refs: nodejs/security-wg#973
PR-URL: #48184
Reviewed-By: Marco Ippolito marcoippolito54@gmail.com
Reviewed-By: Mestery mestery@protonmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Debadree Chatterjee debadree333@gmail.com

[detached HEAD d1cc2af363] tools: Revert spacing before comments
Author: lutaok lucadig.1994@gmail.com
Date: Fri May 26 13:36:31 2023 +0200
1 file changed, 5 insertions(+), 5 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/5108545422

@debadree25 debadree25 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit 607c8f4 into nodejs:main May 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 607c8f4

targos pushed a commit that referenced this pull request May 30, 2023
Refs: nodejs/security-wg#973
PR-URL: #48184
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@targos targos mentioned this pull request Jun 4, 2023
@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jun 30, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Refs: nodejs/security-wg#973
PR-URL: nodejs#48184
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Refs: nodejs/security-wg#973
PR-URL: nodejs#48184
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants