-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: order dependency jobs alphabetically #48184
tools: order dependency jobs alphabetically #48184
Conversation
Review requested:
|
Commit Queue failed- Loading data for nodejs/node/pull/48184 ✔ Done loading data for nodejs/node/pull/48184 ----------------------------------- PR info ------------------------------------ Title tools: order dependency jobs alphabetically (#48184) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch lutaok:jobs-dependencies-alphabetic-order -> nodejs:main Labels meta, author ready Commits 3 - tools: order dependency jobs alphabetically - tools: add missing dependencies options - tools: Revert spacing before comments Committers 1 - lutaok PR-URL: https://github.com/nodejs/node/pull/48184 Reviewed-By: Marco Ippolito Reviewed-By: Mestery Reviewed-By: Luigi Pinca Reviewed-By: Debadree Chatterjee ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48184 Reviewed-By: Marco Ippolito Reviewed-By: Mestery Reviewed-By: Luigi Pinca Reviewed-By: Debadree Chatterjee -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 26 May 2023 07:01:21 GMT ✔ Approvals: 4 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/48184#pullrequestreview-1446499944 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/48184#pullrequestreview-1446788888 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48184#pullrequestreview-1447507295 ✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/48184#pullrequestreview-1448806651 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD 023e8803f8..b47fce0762 main -> origin/main ✔ origin/main is now up-to-date main is out of sync with origin/main. Mismatched commits: - 2b236c8e70 test_runner: remove redundant check from coverage - b47fce0762 test_runner: remove redundant check from coverage -------------------------------------------------------------------------------- HEAD is now at b47fce0762 test_runner: remove redundant check from coverage ✔ Reset to origin/main - Downloading patch for 48184 From https://github.com/nodejs/node * branch refs/pull/48184/merge -> FETCH_HEAD ✔ Fetched commits as b47fce07620a..3be7024073da -------------------------------------------------------------------------------- [main adeba4d8f0] tools: order dependency jobs alphabetically Author: lutaok Date: Fri May 26 08:49:48 2023 +0200 1 file changed, 98 insertions(+), 98 deletions(-) [main 84200f7809] tools: add missing dependencies options Author: lutaok Date: Fri May 26 08:58:16 2023 +0200 1 file changed, 2 insertions(+) [main 6d043268e8] tools: Revert spacing before comments Author: lutaok Date: Fri May 26 13:36:31 2023 +0200 1 file changed, 5 insertions(+), 5 deletions(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6)https://github.com/nodejs/node/actions/runs/5108545422 |
Landed in 607c8f4 |
Refs: nodejs/security-wg#973 PR-URL: #48184 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Refs: nodejs/security-wg#973 PR-URL: nodejs#48184 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Refs: nodejs/security-wg#973 PR-URL: nodejs#48184 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Hi everyone,
I opened this PR to tackle the last bullet point of this issue where jobs in
tools.yml
were not ordered alphabetically.I also added the following options in
workflow_dispatch
, that were missing: