Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix broken link to new folder doc/contributing/maintaining #48205

Merged
merged 1 commit into from
May 28, 2023
Merged

doc: fix broken link to new folder doc/contributing/maintaining #48205

merged 1 commit into from
May 28, 2023

Conversation

fasenderos
Copy link
Contributor

@fasenderos fasenderos commented May 27, 2023 •
edited
Loading

Update broken links to new folder doc/contributing/maintaining (#47589)

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. tools Issues and PRs related to the tools directory. labels May 27, 2023
@aduh95 aduh95 added doc Issues and PRs related to the documentations. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. labels May 27, 2023
@VoltrexKeyva VoltrexKeyva added the fast-track PRs that do not need to wait for 48 hours to land. label May 27, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @VoltrexKeyva. Please 👍 to approve.

aduh95 pushed a commit to fasenderos/node that referenced this pull request May 28, 2023
@fasenderos @aduh95
doc: fix broken link to new folder doc/contributing/maintaining
f43f1e6 
PR-URL: nodejs#48205
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@fasenderos @aduh95
doc: fix broken link to new folder doc/contributing/maintaining
2423624 
PR-URL: nodejs#48205
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@aduh95 aduh95 force-pushed the fix-broken-links branch 2 times, most recently from f43f1e6 to 2423624 Compare May 28, 2023 19:28
@aduh95
Copy link
Contributor

aduh95 commented May 28, 2023

Landed in 2423624

@aduh95 aduh95 merged commit 2423624 into nodejs:main May 28, 2023
targos pushed a commit that referenced this pull request May 30, 2023
@fasenderos @targos
doc: fix broken link to new folder doc/contributing/maintaining
360df25 
PR-URL: #48205
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request Jun 4, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@fasenderos @danielleadams
doc: fix broken link to new folder doc/contributing/maintaining
4179b93 
PR-URL: #48205
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@fasenderos @MoLow
doc: fix broken link to new folder doc/contributing/maintaining
67b2c2a 
PR-URL: nodejs#48205
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@fasenderos @Ceres6
doc: fix broken link to new folder doc/contributing/maintaining
1e593fa 
PR-URL: nodejs#48205
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@fasenderos @Ceres6
doc: fix broken link to new folder doc/contributing/maintaining
fe4567f 
PR-URL: nodejs#48205
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@deokjinkim deokjinkim deokjinkim approved these changes

@aduh95 aduh95 aduh95 approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@Mesteery Mesteery Mesteery approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. openssl Issues and PRs related to the OpenSSL dependency. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@fasenderos @nodejs-github-bot @aduh95 @tniessen @deokjinkim @marco-ippolito @Mesteery @VoltrexKeyva