Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "tools: open issue when update workflow fails" #48312

Merged
merged 1 commit into from
Jun 3, 2023
Merged

Revert "tools: open issue when update workflow fails" #48312

merged 1 commit into from
Jun 3, 2023

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Jun 3, 2023 •
edited
Loading

This reverts commit c488558.
the action creates an issue that dep update failed: #48309 but actually worked #48308, while other jobs failed

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 3, 2023
@marco-ippolito marco-ippolito added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Fast-track has been requested by @marco-ippolito. Please 👍 to approve.

@tniessen
Copy link
Member

tniessen commented Jun 3, 2023

Why did the step run at all? #48308 was opened by a manual run, wasn't it?

@marco-ippolito
Copy link
Member Author

Why did the step run at all? #48308 was opened by a manual run, wasn't it?

Yes it was triggered by @anonrig, there is something wrong in the action, reverting this until we figure it out before it starts opening like 20 issues this sunday

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 3, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 3, 2023
@nodejs-github-bot nodejs-github-bot merged commit fdf8ecd into nodejs:main Jun 3, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in fdf8ecd

targos pushed a commit that referenced this pull request Jun 4, 2023
@marco-ippolito @targos
Revert "tools: open issue when update workflow fails"
3e97826 
This reverts commit c488558.

PR-URL: #48312
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Jun 4, 2023
Merged
@marco-ippolito marco-ippolito mentioned this pull request Jun 6, 2023
Closed
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@marco-ippolito @danielleadams
Revert "tools: open issue when update workflow fails"
253f8c4 
This reverts commit c488558.

PR-URL: #48312
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@marco-ippolito @MoLow
Revert "tools: open issue when update workflow fails"
1cde4a4 
This reverts commit c488558.

PR-URL: nodejs#48312
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@marco-ippolito @Ceres6
Revert "tools: open issue when update workflow fails"
10a9575 
This reverts commit c488558.

PR-URL: nodejs#48312
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@marco-ippolito @Ceres6
Revert "tools: open issue when update workflow fails"
9ecfe7b 
This reverts commit c488558.

PR-URL: nodejs#48312
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@aduh95 aduh95 aduh95 approved these changes

@Mesteery Mesteery Mesteery approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marco-ippolito @nodejs-github-bot @tniessen @richardlau @aduh95 @Mesteery