Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update cjs-module-lexer to 1.2.3 #48414

Closed
wants to merge 3 commits into from
Closed

deps: update cjs-module-lexer to 1.2.3 #48414

wants to merge 3 commits into from

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of cjs-module-lexer to 1.2.3.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 11, 2023
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 11, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 11, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52213/

@github-actions github-actions bot mentioned this pull request Jun 12, 2023
Open
22 tasks
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52222/

This was referenced Jun 13, 2023
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Jun 21, 2023
Open
29 tasks
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 23, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52404/

This was referenced Jun 24, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52462/

This was referenced Jun 26, 2023
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52550/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52551/

@mhdawson
Copy link
Member

The CI failures look real and related to the changes in the PR

  • 01:24:51 node:internal/deps/cjs-module-lexer/lexer:1439
    01:24:51
    01:24:51
    01:24:51
    01:24:51 SyntaxError: Invalid or unexpected token
    01:24:51
    01:24:51 make[2]: *** [node.target.mk:13: /home/iojs/build/workspace/node-test-commit-linuxone/out/Release/obj/gen/node_snapshot.cc] Error 1
    01:24:51 rm 7ca6d2e0e496c02eec89b06d001195ec644a79e1.intermediate b05f31e7e9d7b3c347f40bdc5922dd886fcf0917.intermediate 3f044b5df4766084ea5ac9adac651cff95ccdeff.intermediate 8b5f7b79028a97b5bbce91f26f55eb15dc77dac6.intermediate
    01:24:51 make[1]: *** [Makefile:134: node] Error 2

@mhdawson
Copy link
Member

@marco-ippolito looks like this is the first time the updater has run and it seems like it might need some updates?

@marco-ippolito
Copy link
Member

marco-ippolito commented Jun 29, 2023 •
edited
Loading

@marco-ippolito looks like this is the first time the updater has run and it seems like it might need some updates?

I tried it locally but could not reproduce, do you see something related to the changes from this release that could cause this issue?
nodejs/cjs-module-lexer@1.2.2...1.2.3

This was referenced Jun 30, 2023
Open
Open
Open
Open
Open
Open
Open
This was referenced Jul 7, 2023
Open
Open
@aduh95 aduh95 force-pushed the actions/tools-update-cjs-module-lexer branch from b94b960 to 51df6a5 Compare July 15, 2023 14:13
@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 15, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52766/

This was referenced Jul 16, 2023
Open
Open
Open
Open
@mhdawson
Copy link
Member

@marco-ippolito when you say you tried it locally do you mean you tried it locally on the same commit and you see the same failures in the build/test?

@github-actions github-actions bot mentioned this pull request Jul 20, 2023
Open
22 tasks
mhdawson
mhdawson approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

I'm going to close this since there are conflicts and we should get a new up to date PR when the automation runs next.

@mhdawson mhdawson closed this Oct 24, 2023
@targos targos deleted the actions/tools-update-cjs-module-lexer branch October 24, 2023 17:47
@mhdawson
Copy link
Member

@targos was just looking to delete that branch, see you already did :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@MoLow MoLow MoLow approved these changes

@mhdawson mhdawson mhdawson approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nodejs-github-bot @mhdawson @marco-ippolito @lpinca @anonrig @MoLow @VoltrexKeyva @aduh95