-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove unnecessary noop function args to musNotCall()
#48513
Conversation
s/musNotCall/mustNotCall/ in commit message |
test: remove unnecessary noop function args to `mustNotCall()`
Commit Queue failed- Loading data for nodejs/node/pull/48513 ✔ Done loading data for nodejs/node/pull/48513 ----------------------------------- PR info ------------------------------------ Title test: remove unnecessary noop function args to `musNotCall()` (#48513) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:must-not-noop -> nodejs:main Labels test, author ready, needs-ci Commits 2 - test: remove unnecessary noop function args to `musNotCall()` - amend! test: remove unnecessary noop function args to `musNotCall()` Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/48513 Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Harshitha K P ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48513 Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Harshitha K P -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 21 Jun 2023 18:23:06 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48513#pullrequestreview-1491447001 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/48513#pullrequestreview-1491730123 ✔ - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/48513#pullrequestreview-1492586924 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-06-21T21:50:47Z: https://ci.nodejs.org/job/node-test-pull-request/52335/ - Querying data for job/node-test-pull-request/52335/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 48513 From https://github.com/nodejs/node * branch refs/pull/48513/merge -> FETCH_HEAD ✔ Fetched commits as e9340038114f..3eb2f919471f -------------------------------------------------------------------------------- [main dfb982fc7f] test: remove unnecessary noop function args to `musNotCall()` Author: Antoine du Hamel Date: Wed Jun 21 20:18:12 2023 +0200 14 files changed, 17 insertions(+), 18 deletions(-) The previous cherry-pick is now empty, possibly due to conflict resolution. If you wish to commit it anyway, use:https://github.com/nodejs/node/actions/runs/5359408246 |
Landed in d9f394e |
PR-URL: #48513 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: nodejs#48513 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: nodejs#48513 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #48513 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #48513 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
No description provided.