-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: mark test-child-process-stdio-reuse-readable-stdio flaky #48537
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
lpinca:mark/test-child-process-stdio-reuse-readable-stdio-flaky
Jun 25, 2023
Merged
test: mark test-child-process-stdio-reuse-readable-stdio flaky #48537
nodejs-github-bot
merged 1 commit into
nodejs:main
from
lpinca:mark/test-child-process-stdio-reuse-readable-stdio-flaky
Jun 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Jun 24, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 24, 2023
anonrig
approved these changes
Jun 24, 2023
25 tasks
MoLow
approved these changes
Jun 25, 2023
Fast-track has been requested by @MoLow. Please 👍 to approve. |
benjamingr
approved these changes
Jun 25, 2023
MoLow
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jun 25, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jun 25, 2023
Landed in c308054 |
lpinca
deleted the
mark/test-child-process-stdio-reuse-readable-stdio-flaky
branch
June 25, 2023 16:14
This was referenced Jun 26, 2023
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Jun 29, 2023
Refs: nodejs#48300 (comment) Refs: nodejs/reliability#597 (comment) PR-URL: nodejs#48537 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
Refs: #48300 (comment) Refs: nodejs/reliability#597 (comment) PR-URL: #48537 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jul 4, 2023
Refs: #48300 (comment) Refs: nodejs/reliability#597 (comment) Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> PR-URL: #48537
richardlau
pushed a commit
that referenced
this pull request
Jul 11, 2023
Refs: #48300 (comment) Refs: nodejs/reliability#597 (comment) PR-URL: #48537 Backport-PR-URL: #48650 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Refs: nodejs#48300 (comment) Refs: nodejs/reliability#597 (comment) PR-URL: nodejs#48537 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Refs: nodejs#48300 (comment) Refs: nodejs/reliability#597 (comment) PR-URL: nodejs#48537 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
abhishekumar-tyagi
pushed a commit
to abhishekumar-tyagi/node
that referenced
this pull request
May 5, 2024
Refs: nodejs/node#48300 (comment) Refs: nodejs/reliability#597 (comment) PR-URL: nodejs/node#48537 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fast-track
PRs that do not need to wait for 48 hours to land.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #48300 (comment)
Refs: nodejs/reliability#597 (comment)