-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix code type of markdowns #4858
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JacksonTian
commented
Jan 25, 2016
- correct code type in addons.markdown
- add missed code type in crypto.markdown
1. correct code type in addons.markdown 2. add missed code type in crypto.markdown
LGTM |
LGTM |
1 similar comment
LGTM |
silverwind
pushed a commit
that referenced
this pull request
Jan 25, 2016
1. correct code type in addons.markdown 2. add missed code type in crypto.markdown PR-URL: #4858 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Thanks! Landed in accd69e. |
rvagg
pushed a commit
that referenced
this pull request
Jan 26, 2016
1. correct code type in addons.markdown 2. add missed code type in crypto.markdown PR-URL: #4858 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
benjamingr
pushed a commit
to benjamingr/io.js
that referenced
this pull request
Jan 27, 2016
1. correct code type in addons.markdown 2. add missed code type in crypto.markdown PR-URL: nodejs#4858 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
This commit is blocked on being backported until other doc fixes have been backported first |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 22, 2016
1. correct code type in addons.markdown 2. add missed code type in crypto.markdown PR-URL: #4858 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 22, 2016
1. correct code type in addons.markdown 2. add missed code type in crypto.markdown PR-URL: #4858 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
1. correct code type in addons.markdown 2. add missed code type in crypto.markdown PR-URL: #4858 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
1. correct code type in addons.markdown 2. add missed code type in crypto.markdown PR-URL: nodejs#4858 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.