-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: mention git node release prepare #48644
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
RafaelGSS:doc-mention-git-node-release
Jul 6, 2023
Merged
doc: mention git node release prepare #48644
nodejs-github-bot
merged 1 commit into
nodejs:main
from
RafaelGSS:doc-mention-git-node-release
Jul 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
I'd be more inclined to do it after the bugs outlined in nodejs/node-core-utils#686 are fixed. |
Fair enough. I'll work on that too. |
Blocked until nodejs/node-core-utils#686 resolution |
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSS
force-pushed
the
doc-mention-git-node-release
branch
from
July 4, 2023 15:18
d2eefda
to
6a24d2b
Compare
Ready to go |
ruyadorno
approved these changes
Jul 5, 2023
targos
approved these changes
Jul 6, 2023
RafaelGSS
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jul 6, 2023
richardlau
approved these changes
Jul 6, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jul 6, 2023
Landed in bc8750e |
juanarbol
pushed a commit
that referenced
this pull request
Jul 13, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #48644 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: nodejs#48644 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: nodejs#48644 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 11, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #48644 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 13, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #48644 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 17, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #48644 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @nodejs/releasers