-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: make doctool support guides #4866
Conversation
This adds a new html-guides format to the current doctool. It's kind of a hack. I'll make it better, promise.
Looks good.
|
@eljefedelrodeodeljefe There's some discussion on this going on in the Docs WG slack right now if you'd like to weigh in — the question being "should the doctool continue to consume one file at a time, producing one output file at a time, or should we move to the doctool consuming the entire directory and outputting the entire directory?" |
cc'ing @wooorm on this with a question: as we progress with the work of using remark to render both guide documentation and API documentation in the Node repo, do you have an opinion as to whether it would be less friction to work with remark's programmatic API, or its CLI? |
As this is a partially done PR, I cannot advise correctly without knowing where it’s headed. Is there some document which describes where this PR is going? For your question, I’d suggest wrapping your code as a remark plugin, then running remark’s CLI and using said plugin. As an example, I recently included natural language validation in remark (the project) as an internal remark plugin. Something like that plugin might be a good set-up?! |
@Qard, did you miss out |
Uh...yes. It's basically just a copy/paste of the template used for api docs though. We'll need a proper html file at some point. This is all still very much in-progress. Hopefully I'll get some more time to work on it later this week. Going to see if I can adapt the tool some more to run on the entire project at once rather than file-by-file. |
@Qard ... what's the status on this? |
#5408 should supersede this. Closing. |
DO NOT MERGE
This is in-progress work to generate guide html files using the existing doctool. It's not at all ready to merge yet. I just want to get @nodejs/documentation eyes on it to decide if this seems like a valid approach.