test: skip experimental test with pointer compression #48738

cjihrig · 2023-07-11T16:24:54Z

The test test/parallel/test-experimental-shared-value-conveyor.js was added to test the --harmony-struct feature of V8. However, when used with pointer compression, the process crashes. This commit skips the test for pointer compression builds. This change uses a child process because starting a Node pointer compression build with --harmony-struct immediately crashes the process. Once this crash is addressed, this commit can be reverted.

Refs: nodejs/build#3204 (comment)

The test test/parallel/test-experimental-shared-value-conveyor.js was added to test the --harmony-struct feature of V8. However, when used with pointer compression, the process crashes. This commit skips the test for pointer compression builds. This change uses a child process because starting a Node pointer compression build with --harmony-struct immediately crashes the process. Once this crash is addresses, this commit can be reverted.

MoLow · 2023-07-11T16:35:41Z

should the test be part of known_issues?

cjihrig · 2023-07-11T16:40:15Z

I would prefer not to use known_issues since it's specific to a single build type with an experimental flag. Putting something in known_issues means making sure the test always fails.

mhdawson

LGTM

mcollina

lgtm

nodejs-github-bot · 2023-07-13T19:38:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52754/

nodejs-github-bot · 2023-07-14T11:00:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52758/

lpinca · 2023-07-14T12:31:02Z

CI failures seem realted.

test/parallel/test-experimental-shared-value-conveyor.js

Co-authored-by: Richard Lau <rlau@redhat.com>

nodejs-github-bot · 2023-07-15T15:55:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52767/

nodejs-github-bot · 2023-07-15T16:50:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52768/

nodejs-github-bot · 2023-07-15T18:22:42Z

Commit Queue failed

- Loading data for nodejs/node/pull/48738
✔  Done loading data for nodejs/node/pull/48738
----------------------------------- PR info ------------------------------------
Title      test: skip experimental test with pointer compression (#48738)
Author     Colin Ihrig  (@cjihrig)
Branch     cjihrig:pc-test -> nodejs:main
Labels     test, author ready, commit-queue-squash
Commits    2
 - test: skip experimental test with pointer compression
 - Update test/parallel/test-experimental-shared-value-conveyor.js
Committers 2
 - cjihrig 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/48738
Reviewed-By: Moshe Atlow 
Reviewed-By: Michael Dawson 
Reviewed-By: Matteo Collina 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: Luigi Pinca 
Reviewed-By: Richard Lau 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48738
Reviewed-By: Moshe Atlow 
Reviewed-By: Michael Dawson 
Reviewed-By: Matteo Collina 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: Luigi Pinca 
Reviewed-By: Richard Lau 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 11 Jul 2023 16:24:54 GMT
   ✔  Approvals: 6
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48738#pullrequestreview-1524698864
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/48738#pullrequestreview-1525014643
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/48738#pullrequestreview-1525697808
   ✔  - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/48738#pullrequestreview-1529126202
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48738#pullrequestreview-1529136855
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/48738#pullrequestreview-1531530821
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-07-15T16:50:49Z: https://ci.nodejs.org/job/node-test-pull-request/52768/
- Querying data for job/node-test-pull-request/52768/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/5563587926

nodejs-github-bot · 2023-07-16T09:11:00Z

Landed in a4e4a86

The test test/parallel/test-experimental-shared-value-conveyor.js was added to test the --harmony-struct feature of V8. However, when used with pointer compression, the process crashes. This commit skips the test for pointer compression builds. This change uses a child process because starting a Node pointer compression build with --harmony-struct immediately crashes the process. Once this crash is addresses, this commit can be reverted. PR-URL: nodejs#48738 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

The test test/parallel/test-experimental-shared-value-conveyor.js was added to test the --harmony-struct feature of V8. However, when used with pointer compression, the process crashes. This commit skips the test for pointer compression builds. This change uses a child process because starting a Node pointer compression build with --harmony-struct immediately crashes the process. Once this crash is addresses, this commit can be reverted. PR-URL: #48738 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

cjihrig requested review from mcollina and mhdawson July 11, 2023 16:25

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 11, 2023

cjihrig force-pushed the pc-test branch from 6a32382 to a646565 Compare July 11, 2023 16:35

MoLow approved these changes Jul 11, 2023

View reviewed changes

mhdawson approved these changes Jul 11, 2023

View reviewed changes

mcollina approved these changes Jul 12, 2023

View reviewed changes

debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 13, 2023

debadree25 approved these changes Jul 13, 2023

View reviewed changes

debadree25 added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 13, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 13, 2023

lpinca approved these changes Jul 13, 2023

View reviewed changes

richardlau reviewed Jul 14, 2023

View reviewed changes

test/parallel/test-experimental-shared-value-conveyor.js Outdated Show resolved Hide resolved

Update test/parallel/test-experimental-shared-value-conveyor.js

b2efdf5

Co-authored-by: Richard Lau <rlau@redhat.com>

richardlau approved these changes Jul 15, 2023

View reviewed changes

richardlau added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jul 15, 2023

cjihrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jul 15, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 15, 2023

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 16, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 16, 2023

nodejs-github-bot merged commit a4e4a86 into nodejs:main Jul 16, 2023

github-actions bot mentioned this pull request Jul 16, 2023

CI Reliability 2023-07-16 nodejs/reliability#614

Open

23 tasks

cjihrig deleted the pc-test branch July 16, 2023 14:29

This was referenced Jul 17, 2023

CI Reliability 2023-07-17 nodejs/reliability#615

Open

CI Reliability 2023-07-18 nodejs/reliability#616

Open

CI Reliability 2023-07-19 nodejs/reliability#617

Open

CI Reliability 2023-07-20 nodejs/reliability#618

Open

UlisesGascon mentioned this pull request Aug 15, 2023

v20.6.0 proposal #49185

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: skip experimental test with pointer compression #48738

test: skip experimental test with pointer compression #48738

cjihrig commented Jul 11, 2023 •

edited

Loading

MoLow commented Jul 11, 2023

cjihrig commented Jul 11, 2023

mhdawson left a comment

mcollina left a comment

nodejs-github-bot commented Jul 13, 2023

nodejs-github-bot commented Jul 14, 2023

lpinca commented Jul 14, 2023

nodejs-github-bot commented Jul 15, 2023

nodejs-github-bot commented Jul 15, 2023

nodejs-github-bot commented Jul 15, 2023

nodejs-github-bot commented Jul 16, 2023

test: skip experimental test with pointer compression #48738

test: skip experimental test with pointer compression #48738

Conversation

cjihrig commented Jul 11, 2023 • edited Loading

MoLow commented Jul 11, 2023

cjihrig commented Jul 11, 2023

mhdawson left a comment

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Jul 13, 2023

nodejs-github-bot commented Jul 14, 2023

lpinca commented Jul 14, 2023

nodejs-github-bot commented Jul 15, 2023

nodejs-github-bot commented Jul 15, 2023

nodejs-github-bot commented Jul 15, 2023

nodejs-github-bot commented Jul 16, 2023

cjihrig commented Jul 11, 2023 •

edited

Loading