-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: fix type sniffing for properties in JSON generation #4884
Conversation
LGTM with a couple of nits: the commit should target |
@mscdex, done. |
LGTM |
Ping. |
I don't think running CI does anything with |
Not sure what's up with the ARM hosts in CI right now (stuck in pending, won't start a CI run) but everything else is green. This probably isn't even anything anyone will ever run on ARM anyway since it's internal tooling. And CI doesn't even exercise this code, so the CI run is kind of a symbolic gesture more than anything else. So, will land in another minute or two... |
|
PR-URL: nodejs#4884 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Landed in ab45390 |
PR-URL: #4884 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
PR-URL: #4884 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
PR-URL: #4884 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
PR-URL: #4884 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
PR-URL: nodejs#4884 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Before:
(https://nodejs.org/api/modules.json)
After: