Skip to content

doc: improve requireHostHeader #48860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2023
Merged

doc: improve requireHostHeader #48860

merged 1 commit into from
Jul 25, 2023

Conversation

@GuidoPenta
Copy link
Contributor

@GuidoPenta GuidoPenta commented Jul 20, 2023

improved requireHostHeader documentation (daje)

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 20, 2023

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Jul 20, 2023
mcollina
mcollina approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 21, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52882/

lpinca
lpinca approved these changes Jul 21, 2023
View reviewed changes
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 21, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52888/

This was referenced Jul 22, 2023
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Jul 25, 2023
Open
14 tasks
@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 25, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 25, 2023
@nodejs-github-bot nodejs-github-bot merged commit 36c72c8 into nodejs:main Jul 25, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 25, 2023

Landed in 36c72c8

This was referenced Jul 26, 2023
Open
Open
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
@GuidoPenta @Ceres6
doc: improve requireHostHeader
467c69f 
PR-URL: nodejs#48860
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Jul 28, 2023
Open
Open
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
@GuidoPenta
doc: improve requireHostHeader
f1415a6 
PR-URL: nodejs#48860
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
@GuidoPenta
doc: improve requireHostHeader
f9f6205 
PR-URL: nodejs#48860
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@GuidoPenta @Ceres6
doc: improve requireHostHeader
c1cd6ab 
PR-URL: nodejs#48860
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@GuidoPenta @Ceres6
doc: improve requireHostHeader
4097dd3 
PR-URL: nodejs#48860
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@GuidoPenta @UlisesGascon
doc: improve requireHostHeader
6ab2912 
PR-URL: nodejs#48860
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@GuidoPenta @RafaelGSS
doc: improve requireHostHeader
eb7fa4b 
PR-URL: #48860
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@GuidoPenta @RafaelGSS
doc: improve requireHostHeader
5e47308 
PR-URL: #48860
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@mcollina mcollina mcollina approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

+1 more reviewer

@aymen94 aymen94 aymen94 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@GuidoPenta @nodejs-github-bot @mcollina @ShogunPanda @lpinca @aymen94 @marco-ippolito