Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-tls-zero-clear-in flakiness #4888

Closed
wants to merge 1 commit into from
Closed

test: fix test-tls-zero-clear-in flakiness #4888

wants to merge 1 commit into from

Conversation

santigimeno
Copy link
Member

It can happen that the server-side socket is destroyed before the
client-side socket has gracefully closed, thus causing a 'ECONNRESET'
error in this socket. To solve this, also close gracefully in the server
side too.

It tries to solve the following error I'm getting from time to time in a Debian Jessie 64 box:

=== release test-tls-zero-clear-in ===                                         
Path: parallel/test-tls-zero-clear-in
{ Error: read ECONNRESET
    at exports._errnoException (util.js:859:11)
    at TLSWrap.onread (net.js:544:26) code: 'ECONNRESET', errno: 'ECONNRESET', syscall: 'read' }
assert.js:89
  throw new assert.AssertionError({
  ^
AssertionError: false == true
    at process.<anonymous> (/home/sgimeno/node/node/test/parallel/test-tls-zero-clear-in.js:51:10)
    at emitOne (events.js:96:20)
    at process.emit (events.js:183:7)
Command: out/Release/node /home/sgimeno/node/node/test/parallel/test-tls-zero-clear-in.js

@santigimeno
test: fix test-tls-zero-clear-in flakiness
30d2364 
It can happen that the server-side socket is destroyed before the
client-side socket has gracefully closed, thus causing a 'ECONNRESET'
error in this socket. To solve this, also close gracefully in the server
side too.
@mscdex mscdex added tls Issues and PRs related to the tls subsystem. test Issues and PRs related to the tests. labels Jan 27, 2016
@Trott
Copy link
Member

Trott commented Jan 27, 2016

I know it's a small change, but it is TLS, so: /cc @nodejs/crypto

@indutny
Copy link
Member

indutny commented Jan 27, 2016

LGTM if CI is green.

@bnoordhuis
Copy link
Member

LGTM as well. I wanted to start the CI but it's timing out for me...

@jasnell
Copy link
Member

jasnell commented Jan 27, 2016

LGTM if CI is green

@Trott
Copy link
Member

Trott commented Jan 27, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/1407/

@Trott
Copy link
Member

Trott commented Jan 28, 2016

Known flaky unrelated test failure in CI. In other words, looks good.

@Trott
Copy link
Member

Trott commented Jan 28, 2016

Green CI: https://ci.nodejs.org/job/node-test-pull-request/1418/

Trott pushed a commit to Trott/io.js that referenced this pull request Jan 28, 2016
@santigimeno @Trott
test: fix test-tls-zero-clear-in flakiness
795eeb1 
It can happen that the server-side socket is destroyed before the
client-side socket has gracefully closed, thus causing a 'ECONNRESET'
error in this socket. To solve this, also close gracefully in the server
side too.

PR-URL: nodejs#4888
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@Trott
Copy link
Member

Trott commented Jan 28, 2016

Landed in 795eeb1

@Trott Trott closed this Jan 28, 2016
rvagg pushed a commit that referenced this pull request Jan 28, 2016
@santigimeno @rvagg
test: fix test-tls-zero-clear-in flakiness
90d97df 
It can happen that the server-side socket is destroyed before the
client-side socket has gracefully closed, thus causing a 'ECONNRESET'
error in this socket. To solve this, also close gracefully in the server
side too.

PR-URL: #4888
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
rvagg pushed a commit that referenced this pull request Feb 8, 2016
@santigimeno @rvagg
test: fix test-tls-zero-clear-in flakiness
89d1149 
It can happen that the server-side socket is destroyed before the
client-side socket has gracefully closed, thus causing a 'ECONNRESET'
error in this socket. To solve this, also close gracefully in the server
side too.

PR-URL: #4888
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@rvagg rvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
@santigimeno
test: fix test-tls-zero-clear-in flakiness
670de1f 
It can happen that the server-side socket is destroyed before the
client-side socket has gracefully closed, thus causing a 'ECONNRESET'
error in this socket. To solve this, also close gracefully in the server
side too.

PR-URL: #4888
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
@santigimeno
test: fix test-tls-zero-clear-in flakiness
618427c 
It can happen that the server-side socket is destroyed before the
client-side socket has gracefully closed, thus causing a 'ECONNRESET'
error in this socket. To solve this, also close gracefully in the server
side too.

PR-URL: #4888
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@santigimeno
test: fix test-tls-zero-clear-in flakiness
84ead62 
It can happen that the server-side socket is destroyed before the
client-side socket has gracefully closed, thus causing a 'ECONNRESET'
error in this socket. To solve this, also close gracefully in the server
side too.

PR-URL: #4888
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@santigimeno
test: fix test-tls-zero-clear-in flakiness
3ed76bb 
It can happen that the server-side socket is destroyed before the
client-side socket has gracefully closed, thus causing a 'ECONNRESET'
error in this socket. To solve this, also close gracefully in the server
side too.

PR-URL: nodejs#4888
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@santigimeno @Trott @indutny @bnoordhuis @jasnell @mscdex @MylesBorins