Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: ensure getter access do not mutate observable symbols #48897

Merged
merged 1 commit into from
Jul 24, 2023
Merged

url: ensure getter access do not mutate observable symbols #48897

merged 1 commit into from
Jul 24, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jul 23, 2023

/cc @nodejs/url

Refs: #48891
Refs: #48886

@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 23, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52910/

@mscdex
Copy link
Contributor

mscdex commented Jul 23, 2023

Either the actual runtime change is missing or the subsystem prefix should be test:?

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 24, 2023
@nodejs-github-bot nodejs-github-bot merged commit ad0603e into nodejs:main Jul 24, 2023
37 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ad0603e

@aduh95 aduh95 deleted the url-observable-symbols branch July 24, 2023 07:48
aduh95 added a commit to aduh95/node that referenced this pull request Jul 24, 2023
@aduh95
url: ensure getter access do not mutate observable symbols
eb29d9a 
PR-URL: nodejs#48897
Refs: nodejs#48891
Refs: nodejs#48886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
@aduh95 @Ceres6
url: ensure getter access do not mutate observable symbols
6bdb059 
PR-URL: nodejs#48897
Refs: nodejs#48891
Refs: nodejs#48886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
@aduh95
url: ensure getter access do not mutate observable symbols
72690fc 
PR-URL: nodejs#48897
Refs: nodejs#48891
Refs: nodejs#48886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
@aduh95
url: ensure getter access do not mutate observable symbols
b46cac2 
PR-URL: nodejs#48897
Refs: nodejs#48891
Refs: nodejs#48886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@aduh95 @Ceres6
url: ensure getter access do not mutate observable symbols
feb5b5a 
PR-URL: nodejs#48897
Refs: nodejs#48891
Refs: nodejs#48886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@aduh95 @Ceres6
url: ensure getter access do not mutate observable symbols
615b2aa 
PR-URL: nodejs#48897
Refs: nodejs#48891
Refs: nodejs#48886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@aduh95 @UlisesGascon
url: ensure getter access do not mutate observable symbols
a9a0cce 
PR-URL: nodejs#48897
Refs: nodejs#48891
Refs: nodejs#48886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@aduh95 @RafaelGSS
url: ensure getter access do not mutate observable symbols
b12c3b5 
PR-URL: #48897
Refs: #48891
Refs: #48886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Aug 16, 2023
@aduh95 @ruyadorno
url: ensure getter access do not mutate observable symbols
0beb5ab 
PR-URL: #48897
Backport-PR-URL: #48891
Refs: #48891
Refs: #48886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@ruyadorno ruyadorno added the backported-to-v18.x PRs backported to the v18.x-staging branch. label Aug 16, 2023
@ruyadorno ruyadorno mentioned this pull request Aug 17, 2023
Merged
@Rob--W Rob--W mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
backported-to-v18.x PRs backported to the v18.x-staging branch. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @mscdex @anonrig @MoLow @ruyadorno