fs : doc readdir recursive sync & callback #48640 #48902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
lpinca
approved these changes
Jul 26, 2023
anonrig
approved these changes
Sep 30, 2023
anonrig
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/48902 ✔ Done loading data for nodejs/node/pull/48902 ----------------------------------- PR info ------------------------------------ Title fs : doc readdir recursive sync & callback #48640 (#48902) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch RamdohokarAngha:fs-doc-readdir-recursive-sync-&-callback -> nodejs:main Labels doc, fs, author ready, commit-queue-squash Commits 4 - fs : doc readdir recursive sync & callback - Update doc/api/fs.md - Update doc/api/fs.md - Merge branch 'nodejs:main' into fs-doc-readdir-recursive-sync-&-callback Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/48902 Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48902 Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 24 Jul 2023 11:40:08 GMT ✔ Approvals: 2 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48902#pullrequestreview-1548446213 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/48902#pullrequestreview-1651609728 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 48902 From https://github.com/nodejs/node * branch refs/pull/48902/merge -> FETCH_HEAD ✔ Fetched commits as 51f4ff245018..e2cfe24fc05a -------------------------------------------------------------------------------- Auto-merging doc/api/fs.md [main 5931ae8cee] fs : doc readdir recursive sync & callback Author: RamdohokarAngha <91063774+RamdohokarAngha@users.noreply.github.com> Date: Mon Jul 24 17:06:51 2023 +0530 1 file changed, 6 insertions(+), 3 deletions(-) Auto-merging doc/api/fs.md [main 422bc6de18] Update doc/api/fs.md Author: RamdohokarAngha <91063774+RamdohokarAngha@users.noreply.github.com> Date: Wed Aug 16 11:37:49 2023 +0530 1 file changed, 1 insertion(+), 1 deletion(-) Auto-merging doc/api/fs.md error: commit e2cfe24fc05a82df5feff180c6dc5296e6a6f79c is a merge but no -m option was given. fatal: cherry-pick failed [main 1f365ad1d5] Update doc/api/fs.md Author: RamdohokarAngha <91063774+RamdohokarAngha@users.noreply.github.com> Date: Wed Aug 16 11:38:07 2023 +0530 1 file changed, 1 insertion(+), 1 deletion(-) ✘ Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/6359670729 |
aduh95
approved these changes
Oct 6, 2023
|
associated with #48640 |
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 34fa704 |
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#48902 Fixes: nodejs#48640 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
debadree25
pushed a commit
to debadree25/node
that referenced
this pull request
Apr 15, 2024
PR-URL: nodejs#48902 Fixes: nodejs#48640 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #48640