Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: remove weak listener for event target #48952

Merged
merged 19 commits into from
Aug 12, 2023
Merged

events: remove weak listener for event target #48952

merged 19 commits into from
Aug 12, 2023

Commits on Aug 10, 2023

  1. events: remove weak listener for event target 

    Fixes: nodejs#48951
    @rluvaton
    rluvaton committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    9d27708 View commit details
    Browse the repository at this point in the history

  2. pass listener

    @rluvaton
    rluvaton committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    c32cd85 View commit details
    Browse the repository at this point in the history

  3. add test for not leaking memory

    @rluvaton
    rluvaton committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    20a1777 View commit details
    Browse the repository at this point in the history

  4. fix event target not GCed

    @rluvaton
    rluvaton committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    7375d07 View commit details
    Browse the repository at this point in the history

  5. format

    @rluvaton
    rluvaton committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    3fdc3e3 View commit details
    Browse the repository at this point in the history

  6. clean

    @rluvaton
    rluvaton committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    d7e1823 View commit details
    Browse the repository at this point in the history

  7. events: rename to kRemoveListenerHelper and used symbol

    @rluvaton
    rluvaton committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    0471c77 View commit details
    Browse the repository at this point in the history

  8. move AbortSignal.timeout to different test file to be less flaky

    @rluvaton
    rluvaton committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    efbce3e View commit details
    Browse the repository at this point in the history

  9. Update test/parallel/test-abortsignal-timeout.js 

    Co-authored-by: Chemi Atlow <chemi@atlow.co.il>
    @rluvaton @atlowChemi
    rluvaton and atlowChemi committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    86d0270 View commit details
    Browse the repository at this point in the history

  10. rename test

    @rluvaton
    rluvaton committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    a83c38b View commit details
    Browse the repository at this point in the history

  11. revert tests due to them not working

    @rluvaton
    rluvaton committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6002db8 View commit details
    Browse the repository at this point in the history

  12. add test

    @rluvaton
    rluvaton committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    7134b93 View commit details
    Browse the repository at this point in the history

  13. format

    @rluvaton
    rluvaton committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    7a0fde3 View commit details
    Browse the repository at this point in the history

  14. add back the tests

    @rluvaton
    rluvaton committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    f7dd524 View commit details
    Browse the repository at this point in the history

  15. increase sleep in test

    @rluvaton
    rluvaton committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    a85adaf View commit details
    Browse the repository at this point in the history

  16. test: test that memory leak warning not emitted for weak refs that go… 

    …t cleaned
    @rluvaton
    rluvaton committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    9ab6de6 View commit details
    Browse the repository at this point in the history

  17. events: rename kRemoveListenerHelper to indicate it's only for weak l… 

    …isteners
    @rluvaton
    rluvaton committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    5f8e448 View commit details
    Browse the repository at this point in the history

  18. Update test/parallel/test-eventtarget-memoryleakwarning.js 

    Co-authored-by: Chemi Atlow <chemi@atlow.co.il>
    @rluvaton @atlowChemi
    rluvaton and atlowChemi committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    3b1266e View commit details
    Browse the repository at this point in the history

  19. use symbol

    @rluvaton
    rluvaton committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    ece725c View commit details
    Browse the repository at this point in the history