-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove --no-warnings
flag in test_runner
fixtures
#48989
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
rluvaton:remove-no-warning-in-test-output
Aug 3, 2023
Merged
test: remove --no-warnings
flag in test_runner
fixtures
#48989
nodejs-github-bot
merged 1 commit into
nodejs:main
from
rluvaton:remove-no-warning-in-test-output
Aug 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no longer needed after nodejs#48915 fix
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Aug 1, 2023
MoLow
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
atlowChemi
approved these changes
Aug 2, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 2, 2023
Seems unrelated can you please retry? |
29 tasks
MoLow
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 3, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 3, 2023
Landed in 1353681 |
25 tasks
pluris
pushed a commit
to pluris/node
that referenced
this pull request
Aug 6, 2023
no longer needed after nodejs#48915 fix PR-URL: nodejs#48989 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
pluris
pushed a commit
to pluris/node
that referenced
this pull request
Aug 7, 2023
no longer needed after nodejs#48915 fix PR-URL: nodejs#48989 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
no longer needed after nodejs#48915 fix PR-URL: nodejs#48989 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
no longer needed after nodejs#48915 fix PR-URL: nodejs#48989 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
UlisesGascon
pushed a commit
to UlisesGascon/node
that referenced
this pull request
Aug 14, 2023
no longer needed after nodejs#48915 fix PR-URL: nodejs#48989 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Merged
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Aug 15, 2023
no longer needed after nodejs#48915 fix PR-URL: nodejs#48989 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
rluvaton
added a commit
to rluvaton/node
that referenced
this pull request
Aug 15, 2023
no longer needed after nodejs#48915 fix PR-URL: nodejs#48989 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
RafaelGSS
added
the
backport-requested-v20.x
PRs awaiting manual backport to the v20.x-staging branch.
label
Aug 17, 2023
Due to fact, #48877 didn't land cleanly on v20.x-staging. This PR somehow, depends on it. So we'll need a manual backport. |
rluvaton
added a commit
to rluvaton/node
that referenced
this pull request
Aug 18, 2023
no longer needed after nodejs#48915 fix PR-URL: nodejs#48989 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
rluvaton
added
backport-open-v20.x
Indicate that the PR has an open backport
and removed
backport-requested-v20.x
PRs awaiting manual backport to the v20.x-staging branch.
labels
Aug 18, 2023
rluvaton
added a commit
to rluvaton/node
that referenced
this pull request
Sep 4, 2023
no longer needed after nodejs#48915 fix PR-URL: nodejs#48989 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Merged
targos
added
backported-to-v20.x
PRs backported to the v20.x-staging branch.
and removed
backport-open-v20.x
Indicate that the PR has an open backport
labels
Nov 12, 2023
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
no longer needed after #48915 fix PR-URL: nodejs/node#48989 Backport-PR-URL: nodejs/node#49225 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
no longer needed after #48915 fix PR-URL: nodejs/node#48989 Backport-PR-URL: nodejs/node#49225 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backported-to-v20.x
PRs backported to the v20.x-staging branch.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no longer needed after #48915 fix