Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x] doc: include git add -f to include folder #49004

Closed
wants to merge 1 commit into from
Closed

[v16.x] doc: include git add -f to include folder #49004

wants to merge 1 commit into from

Conversation

RafaelGSS
Copy link
Member

Ref:

$ git add deps/openssl/openssl/include/openssl/opensslconf.h
The following paths are ignored by one of your .gitignore files:
deps/openssl/openssl/include/openssl/opensslconf.h
hint: Use -f if you really want to add them.
hint: Turn this message off by running
hint: "git config advice.addIgnoredFile false"

The .gitignore from quictls/openssl is read by git so we need to force include it

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@RafaelGSS RafaelGSS added the v16.x label Aug 3, 2023
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 3, 2023
@RafaelGSS RafaelGSS changed the title doc: include git add -f to include folder [v16.x] doc: include git add -f to include folder Aug 3, 2023
@richardlau
Copy link
Member

The .gitignore from quictls/openssl is read by git so we need to force include it

I don't object to the change being proposed by this PR, but it should be unnecessary -- the .gitignore file being referenced should have been removed by

node/doc/contributing/maintaining-openssl.md

Line 70 in 76f9a7d

% rm -rf openssl/.git* openssl/.travis*

@richardlau richardlau mentioned this pull request Aug 24, 2023
Closed
@RafaelGSS RafaelGSS closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymen94 aymen94 aymen94 approved these changes

@anonrig anonrig anonrig approved these changes

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RafaelGSS @nodejs-github-bot @richardlau @ruyadorno @anonrig @aymen94