-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix compiler warning in NodeCryptoEnv #49206
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
tniessen:test-node-crypto-env-compiler-warning
Aug 24, 2023
Merged
test: fix compiler warning in NodeCryptoEnv #49206
nodejs-github-bot
merged 1 commit into
nodejs:main
from
tniessen:test-node-crypto-env-compiler-warning
Aug 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a warning in line 26: "warning: value computed is not used" when calling BIO_seek(). Refs: nodejs#47160
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Aug 16, 2023
tniessen
added
c++
Issues and PRs that require attention from people who are familiar with C++.
crypto
Issues and PRs related to the crypto subsystem.
review wanted
PRs that need reviews.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 20, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 23, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
mhdawson
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
27 tasks
tniessen
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 24, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 24, 2023
Landed in 6117cc3 |
This was referenced Aug 25, 2023
Merged
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
This fixes a warning in line 26: "warning: value computed is not used" when calling BIO_seek(). Refs: nodejs#47160 PR-URL: nodejs#49206 Reviewed-By: Michael Dawson <midawson@redhat.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
This fixes a warning in line 26: "warning: value computed is not used" when calling BIO_seek(). Refs: nodejs/node#47160 PR-URL: nodejs/node#49206 Reviewed-By: Michael Dawson <midawson@redhat.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
This fixes a warning in line 26: "warning: value computed is not used" when calling BIO_seek(). Refs: nodejs/node#47160 PR-URL: nodejs/node#49206 Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
warning: value computed is not used
when callingBIO_seek()
:Refs: #47160