Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve UV_THREADPOOL_SIZE tests on .env #49213

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Aug 17, 2023

Follow up after @tniessen's pull request #49165

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 17, 2023
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 17, 2023
@nodejs-github-bot
Copy link
Collaborator

test/parallel/test-dotenv-node-options.js Outdated Show resolved Hide resolved
@anonrig anonrig mentioned this pull request Aug 17, 2023
8 tasks
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2023
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 19, 2023
@nodejs-github-bot
Copy link
Collaborator

@aduh95
Copy link
Contributor

aduh95 commented Aug 26, 2023

parallel.test-dotenv-node-options is failing on a few platforms

@aduh95 aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 26, 2023
@tniessen
Copy link
Member

Looking at the error messages, this is likely due to some platforms not running the node-api tests, either not at all or not on the same machine that runs this test. Does that sound right @richardlau? If that's the case, perhaps just skip the test if the file is missing.

@richardlau
Copy link
Member

Looking at the error messages, this is likely due to some platforms not running the node-api tests, either not at all or not on the same machine that runs this test. Does that sound right @richardlau?

Yes, that is correct. If the test needs the addon from test/node-api/test_uv_threadpool_size it should live in test/node-api/test_uv_threadpool_size.

@tniessen
Copy link
Member

I agree that that makes sense, but FWIW, there is precedent for skipping parts of tests when a shared library is missing:

const engine = path.join(__dirname,
`/build/${common.buildType}/testsetengine.engine`);
if (!fs.existsSync(engine))
common.skip('no engine');

@richardlau
Copy link
Member

@tniessen In that particular case I think it's because the engine is not compiled on all platforms:

['(OS=="mac" or OS=="linux") and '
'node_use_openssl=="true" and '
'node_shared=="false" and '
'node_shared_openssl=="false"', {

That is not the case for test/node-api/test_uv_threadpool_size, which is compiled for all platforms.

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2023
@nodejs-github-bot
Copy link
Collaborator

@GeoffreyBooth GeoffreyBooth added the cli Issues and PRs related to the Node.js command line interface. label Sep 2, 2023
@anonrig
Copy link
Member Author

anonrig commented Oct 31, 2023

@anonrig any thoughts on my findings/suggestions?

Thank you @StefanStojanovic. I've applied your suggestions.

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Copy link
Contributor

@StefanStojanovic StefanStojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 3, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 3, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/49213
✔  Done loading data for nodejs/node/pull/49213
----------------------------------- PR info ------------------------------------
Title      test: improve `UV_THREADPOOL_SIZE` tests on `.env` (#49213)
Author     Yagiz Nizipli  (@anonrig)
Branch     anonrig:test-dotenv-improve -> nodejs:main
Labels     test, cli, needs-ci
Commits    1
 - test: improve `UV_THREADPOOL_SIZE` tests on `.env`
Committers 1
 - Yagiz Nizipli 
PR-URL: https://github.com/nodejs/node/pull/49213
Reviewed-By: Chemi Atlow 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49213
Reviewed-By: Chemi Atlow 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - test: improve `UV_THREADPOOL_SIZE` tests on `.env`
   ℹ  This PR was created on Thu, 17 Aug 2023 14:19:12 GMT
   ✔  Approvals: 1
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/49213#pullrequestreview-1585715138
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-11-01T01:47:03Z: https://ci.nodejs.org/job/node-test-pull-request/55373/
- Querying data for job/node-test-pull-request/55373/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6748150235

@anonrig anonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 3, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 3, 2023
@nodejs-github-bot nodejs-github-bot merged commit 4dbb017 into nodejs:main Nov 3, 2023
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4dbb017

anonrig added a commit to anonrig/node that referenced this pull request Nov 9, 2023
PR-URL: nodejs#49213
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #49213
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
targos pushed a commit that referenced this pull request Nov 14, 2023
PR-URL: #49213
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
PR-URL: #49213
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues and PRs related to the Node.js command line interface. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants