test: improve UV_THREADPOOL_SIZE tests on .env

[anonrig]

Follow up after @tniessen's pull request #49165

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/53403/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/53447/

[aduh95]

parallel.test-dotenv-node-options is failing on a few platforms

[tniessen]

Looking at the error messages, this is likely due to some platforms not running the node-api tests, either not at all or not on the same machine that runs this test. Does that sound right @richardlau? If that's the case, perhaps just skip the test if the file is missing.

[richardlau]

Looking at the error messages, this is likely due to some platforms not running the node-api tests, either not at all or not on the same machine that runs this test. Does that sound right @richardlau?

Yes, that is correct. If the test needs the addon from test/node-api/test_uv_threadpool_size it should live in test/node-api/test_uv_threadpool_size.

[tniessen]

I agree that that makes sense, but FWIW, there is precedent for skipping parts of tests when a shared library is missing:

node/test/addons/openssl-test-engine/test.js

Lines 34 to 38 in 9cd70f4

	const engine = path.join(__dirname,
	`/build/${common.buildType}/testsetengine.engine`);
	if (!fs.existsSync(engine))
	common.skip('no engine');

[richardlau]

@tniessen In that particular case I think it's because the engine is not compiled on all platforms:

node/test/addons/openssl-test-engine/binding.gyp

Lines 8 to 11 in 9cd70f4

	['(OS=="mac" or OS=="linux") and '
	'node_use_openssl=="true" and '
	'node_shared=="false" and '
	'node_shared_openssl=="false"', {

That is not the case for test/node-api/test_uv_threadpool_size, which is compiled for all platforms.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/53628/

[anonrig]

@anonrig any thoughts on my findings/suggestions?

Thank you @StefanStojanovic. I've applied your suggestions.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55361/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55370/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55373/

[StefanStojanovic]

LGTM

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/49213
✔  Done loading data for nodejs/node/pull/49213
----------------------------------- PR info ------------------------------------
Title      test: improve `UV_THREADPOOL_SIZE` tests on `.env` (#49213)
Author     Yagiz Nizipli  (@anonrig)
Branch     anonrig:test-dotenv-improve -> nodejs:main
Labels     test, cli, needs-ci
Commits    1
 - test: improve `UV_THREADPOOL_SIZE` tests on `.env`
Committers 1
 - Yagiz Nizipli 
PR-URL: https://github.com/nodejs/node/pull/49213
Reviewed-By: Chemi Atlow 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49213
Reviewed-By: Chemi Atlow 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - test: improve `UV_THREADPOOL_SIZE` tests on `.env`
   ℹ  This PR was created on Thu, 17 Aug 2023 14:19:12 GMT
   ✔  Approvals: 1
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/49213#pullrequestreview-1585715138
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-11-01T01:47:03Z: https://ci.nodejs.org/job/node-test-pull-request/55373/
- Querying data for job/node-test-pull-request/55373/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6748150235

[nodejs-github-bot]

Landed in 4dbb017