-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add assertion for TLS peer certificate fingerprint #4923
Conversation
LGTM but can you amend the commit log so it conforms to the guidelines from CONTRIBUTING.md? In particular, it should start with the subsystem ( CI: https://ci.nodejs.org/job/node-test-pull-request/1419/ (currently private because of the upcoming security release.) |
8734d1b
to
48afa53
Compare
Thanks @bnoordhuis. Just updated the commit message |
LGTM |
@LumberJ Can you run
|
PR-URL: nodejs#4923 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
48afa53
to
7b61f02
Compare
Thanks, just fixed the lint error. On Fri, Jan 29, 2016 at 12:36 AM, Ben Noordhuis notifications@github.com
Alan Cohen |
PR-URL: #4923 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in 59fb26c |
PR-URL: #4923 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #4923 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #4923 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #4923 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#4923 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #4923
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl