Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: edit import.meta.resolve documentation #49247

Merged
merged 3 commits into from
Sep 5, 2023
Merged

doc: edit import.meta.resolve documentation #49247

merged 3 commits into from
Sep 5, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Aug 19, 2023 •
edited
Loading

  • add missing history entry.
  • fix the return value description:
    • The return value doesn't have to be a file: URL, it can be of any scheme.
    • The return value doesn't have to correspond to a module, it can be a directory or something that doesn't exist.
  • merge the two code examples, remove the use of the non-standard second argument.
  • merge the two caveats.
  • do not mention the old implementation, the history section is already there for that.

Refs: #49028

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Aug 19, 2023
JakobJingleheimer
JakobJingleheimer reviewed Aug 19, 2023
View reviewed changes
doc/api/esm.md Show resolved Hide resolved
doc/api/esm.md Outdated Show resolved Hide resolved
GeoffreyBooth
GeoffreyBooth approved these changes Aug 19, 2023
View reviewed changes
doc/api/esm.md Outdated Show resolved Hide resolved
doc/api/esm.md Show resolved Hide resolved
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 19, 2023
@GeoffreyBooth GeoffreyBooth added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 19, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve.

@GeoffreyBooth
Copy link
Member

GeoffreyBooth commented Aug 19, 2023 •
edited by aduh95
Loading

Adding fast-track PRs that do not need to wait for 48 hours to land. in case it’s possible to add this to Monday’s release.

@GeoffreyBooth GeoffreyBooth mentioned this pull request Aug 19, 2023
Merged
@joyeecheung
Copy link
Member

This needs a rebase

@aduh95 aduh95 force-pushed the import-meta-resolve branch from 6f1be92 to d20e630 Compare September 4, 2023 21:02
@aduh95 aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Sep 4, 2023
@GeoffreyBooth GeoffreyBooth added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2023
@nodejs-github-bot nodejs-github-bot merged commit e11c7b7 into nodejs:main Sep 5, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in e11c7b7

@aduh95 aduh95 deleted the import-meta-resolve branch September 5, 2023 08:06
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@aduh95 @ruyadorno
doc: edit import.meta.resolve documentation
b9d4a80 
PR-URL: #49247
Refs: #49028
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@aduh95 @alexfernandez
doc: edit import.meta.resolve documentation
e76e9a8 
PR-URL: nodejs#49247
Refs: nodejs#49028
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95 @targos
doc: edit import.meta.resolve documentation
16580a4 
PR-URL: nodejs#49247
Refs: nodejs#49028
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@targos targos mentioned this pull request Nov 11, 2023
Closed
@targos targos added the backported-to-v18.x PRs backported to the v18.x-staging branch. label Nov 23, 2023
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95 @targos
doc: edit import.meta.resolve documentation
c20fdb4 
PR-URL: #49247
Backport-PR-URL: #50669
Refs: #49028
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: edit import.meta.resolve documentation
11700d7 
PR-URL: nodejs/node#49247
Backport-PR-URL: nodejs/node#50669
Refs: nodejs/node#49028
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: edit import.meta.resolve documentation
054b934 
PR-URL: nodejs/node#49247
Backport-PR-URL: nodejs/node#50669
Refs: nodejs/node#49028
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobJingleheimer JakobJingleheimer JakobJingleheimer left review comments

@aymen94 aymen94 aymen94 approved these changes

@guybedford guybedford guybedford approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aduh95 @nodejs-github-bot @GeoffreyBooth @joyeecheung @guybedford @JakobJingleheimer @aymen94 @targos