Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update description of percent_encode set in WHATWG API #49258

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

pluris
Copy link
Contributor

@pluris pluris commented Aug 20, 2023

The character code is shown in the description of percent-encoded-bytes in the WHATWG URL Spec.
I think it would be better for readability to show the 'character code' the same as the WHATWG URL.

Refs: https://url.spec.whatwg.org/#percent-encoded-bytes

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Aug 20, 2023
@daeyeon
Copy link
Member

daeyeon commented Aug 22, 2023

Please fix the markdown lint error. make lint-md can check it locally.

@pluris
Copy link
Contributor Author

pluris commented Aug 22, 2023

@daeyeon Hi, Thank you for your comment. I fixed it.

@daeyeon daeyeon added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 22, 2023
@daeyeon daeyeon added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2023
@nodejs-github-bot nodejs-github-bot merged commit 56a2a2e into nodejs:main Aug 23, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 56a2a2e

@pluris pluris deleted the doc/readablity_url branch August 30, 2023 16:12
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
PR-URL: #49258
Refs: https://url.spec.whatwg.org/#percent-encoded-bytes
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
PR-URL: nodejs#49258
Refs: https://url.spec.whatwg.org/#percent-encoded-bytes
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2023
PR-URL: #49258
Refs: https://url.spec.whatwg.org/#percent-encoded-bytes
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#49258
Refs: https://url.spec.whatwg.org/#percent-encoded-bytes
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#49258
Refs: https://url.spec.whatwg.org/#percent-encoded-bytes
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants