Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused PromiseWrap-related code #49335

Merged
merged 1 commit into from
Sep 1, 2023

Commits on Aug 26, 2023

  1. src: remove unused PromiseWrap-related code

    PromiseWrap has been removed in
    nodejs#39135 and we do not have any
    internal object setting the internal field at 0 as a promise
    (we always set the first field as an aligned pointer to
    the embedder ID). As result GetAssignedPromiseWrapAsyncId()
    always just returns AsyncWrap::kInvalidAsyncId and turn
    the removed block into noops. So the block just can be removed.
    joyeecheung committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    1647d31 View commit details
    Browse the repository at this point in the history