Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rename test-crypto-modp1-error #49348

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

tniessen
Copy link
Member

This test is not specific to 'modp1' at all, it might as well use any of the other groups.

Refs: #40451

This test is not specific to modp1 at all, it might as well use any of
the other groups.

Refs: nodejs#40451
@tniessen tniessen added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. labels Aug 27, 2023
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 27, 2023
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 28, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2023
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@tniessen
Copy link
Member Author

CI infra is broken, see nodejs/build#3475.

@nodejs-github-bot
Copy link
Collaborator

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit 452bae1 into nodejs:main Aug 29, 2023
40 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 452bae1

UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
This test is not specific to modp1 at all, it might as well use any of
the other groups.

Refs: #40451
PR-URL: #49348
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
This test is not specific to modp1 at all, it might as well use any of
the other groups.

Refs: nodejs#40451
PR-URL: nodejs#49348
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2023
This test is not specific to modp1 at all, it might as well use any of
the other groups.

Refs: #40451
PR-URL: #49348
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
This test is not specific to modp1 at all, it might as well use any of
the other groups.

Refs: nodejs/node#40451
PR-URL: nodejs/node#49348
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
This test is not specific to modp1 at all, it might as well use any of
the other groups.

Refs: nodejs/node#40451
PR-URL: nodejs/node#49348
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants