Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update undici to 5.25.2 #49559

Merged
merged 3 commits into from
Sep 23, 2023
Merged

deps: update undici to 5.25.2 #49559

merged 3 commits into from
Sep 23, 2023

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Sep 8, 2023 •
edited
Loading

This is an automated update of undici to 5.25.2.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 8, 2023
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/53819/

@aduh95
Copy link
Contributor

aduh95 commented Sep 8, 2023

Quite a few seemingly related test failures

@KhafraDev
Copy link
Member

is it only builds without ssl?

This was referenced Sep 9, 2023
Open
Open
Open
@joyeecheung joyeecheung mentioned this pull request Sep 11, 2023
Open
@github-actions github-actions bot mentioned this pull request Sep 12, 2023
Open
19 tasks
@atlowChemi atlowChemi mentioned this pull request Sep 13, 2023
Closed
@atlowChemi atlowChemi linked an issue Sep 13, 2023 that may be closed by this pull request
Unexpected error when using signal with reason in fetch #49557
Closed
@KhafraDev KhafraDev mentioned this pull request Sep 19, 2023
Merged
@nodejs-github-bot nodejs-github-bot changed the title deps: update undici to 5.24.0 deps: update undici to 5.25.0 Sep 20, 2023
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2023
mcollina
mcollina approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/54106/

@github-actions github-actions bot mentioned this pull request Sep 22, 2023
Open
17 tasks
@nodejs-github-bot nodejs-github-bot changed the title deps: update undici to 5.25.0 deps: update undici to 5.25.2 Sep 22, 2023
@mcollina
Copy link
Member

@KhafraDev let's see if WebSocket runs :)

@KhafraDev
Copy link
Member

I tested it locally, there is something very strange going on if it doesn't work lol

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/54170/

@github-actions github-actions bot mentioned this pull request Sep 23, 2023
Open
16 tasks
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/54175/

@mcollina mcollina added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Sep 23, 2023
mcollina
mcollina approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 23, 2023
@nodejs-github-bot nodejs-github-bot merged commit ef062b9 into main Sep 23, 2023
58 checks passed
@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-undici branch September 23, 2023 11:40
@nodejs-github-bot
Copy link
Collaborator Author

Landed in ef062b9

@github-actions github-actions bot mentioned this pull request Sep 24, 2023
Open
20 tasks
@joyeecheung joyeecheung mentioned this pull request Sep 25, 2023
Closed
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@nodejs-github-bot @ruyadorno
deps: update undici to 5.24.0
61d18d6 
PR-URL: #49559
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@nodejs-github-bot @alexfernandez
deps: update undici to 5.24.0
de9a202 
PR-URL: nodejs#49559
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
@targos targos added the backported-to-v18.x PRs backported to the v18.x-staging branch. label Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@KhafraDev KhafraDev KhafraDev approved these changes

@ronag ronag Awaiting requested review from ronag

Assignees
No one assigned
Labels
backported-to-v18.x PRs backported to the v18.x-staging branch. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected error when using signal with reason in fetch
5 participants
@nodejs-github-bot @aduh95 @KhafraDev @mcollina @targos