Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: deflake test-http-regr-gh-2928 #49574

Closed
wants to merge 1 commit into from
Closed

test: deflake test-http-regr-gh-2928 #49574

wants to merge 1 commit into from

Commits on Sep 10, 2023

  1. test: deflake test-http-regr-nodejsgh-2928 

    Hard code the value of the host parameter to `common.localhostIPv4` in
`server.listen()` and `net.connect()`. This

1. ensures that the client `socket._handle` is not reinitialized during
   connection due to the family autodetection algorithm, preventing
   `parser.consume()` from being called with an invalid `socket._handle`
   parameter.
2. works around an issue in the FreeBSD 12 machine where the stress test
   is run where some sockets get stuck after connection.

Closes: nodejs#49565
Fixes: nodejs#49564
    @lpinca
    lpinca committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    6db17f7 View commit details
    Browse the repository at this point in the history