Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] lib: add option to force handling stopped events #49587

Closed
wants to merge 1 commit into from
Closed

[v18.x backport] lib: add option to force handling stopped events #49587

wants to merge 1 commit into from

Conversation

atlowChemi
Copy link
Member

No description provided.

@atlowChemi
lib: add option to force handling stopped events
832ee65 
PR-URL: nodejs#48301
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/tsc
  • @nodejs/url

@atlowChemi atlowChemi changed the base branch from v18.x to v18.x-staging September 10, 2023 07:33
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Sep 10, 2023
@atlowChemi atlowChemi added eventtarget Issues and PRs related to the EventTarget implementation. request-ci Add this label to start a Jenkins CI on a PR. and removed doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. dependencies Pull requests that update a dependency file. labels Sep 10, 2023
@atlowChemi atlowChemi mentioned this pull request Sep 10, 2023
Merged
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 10, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53859/

@aduh95 aduh95 changed the title Backport 48301 to 18 [v18.x backport] lib: add option to force handling stopped events Sep 10, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53862/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53864/

@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Open
18 tasks
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@atlowChemi @ruyadorno
lib: add option to force handling stopped events
dbaa2cc 
PR-URL: #48301
Backport-PR-URL: #49587
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@ruyadorno
Copy link
Member

Landed in dbaa2cc

@ruyadorno ruyadorno closed this Sep 11, 2023
@github-actions github-actions bot mentioned this pull request Sep 12, 2023
Open
19 tasks
@github-actions github-actions bot mentioned this pull request Sep 13, 2023
Open
14 tasks
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@atlowChemi @ruyadorno
lib: add option to force handling stopped events
db355d1 
PR-URL: #48301
Backport-PR-URL: #49587
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This was referenced Sep 14, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
eventtarget Issues and PRs related to the EventTarget implementation. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atlowChemi @nodejs-github-bot @ruyadorno