benchmark: add a benchmark for read() of ReadableStreams #49622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
benchmark
H4ad
reviewed
Sep 12, 2023
H4ad
reviewed
Sep 12, 2023
anonrig
approved these changes
Sep 13, 2023
debadree25
added
the
author ready
H4ad
approved these changes
Sep 13, 2023
anonrig
added
the
performance
debadree25
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/49622 ✔ Done loading data for nodejs/node/pull/49622 ----------------------------------- PR info ------------------------------------ Title benchmark: add a benchmark for read() of ReadableStreams (#49622) Author Debadree Chatterjee (@debadree25) Branch debadree25:ft/bench-readable-read -> nodejs:main Labels benchmark, performance, author ready Commits 2 - benchmark: add a benchmark for read() of ReadableStreams - fixup! lint Committers 1 - Debadree Chatterjee PR-URL: https://github.com/nodejs/node/pull/49622 Refs: https://github.com/nodejs/performance/issues/82 Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49622 Refs: https://github.com/nodejs/performance/issues/82 Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 12 Sep 2023 10:42:20 GMT ✔ Approvals: 1 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49622#pullrequestreview-1623539599 ✘ This PR needs to wait 29 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6218493460 |
|
ah needs another approval |
debadree25
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/49622 ✔ Done loading data for nodejs/node/pull/49622 ----------------------------------- PR info ------------------------------------ Title benchmark: add a benchmark for read() of ReadableStreams (#49622) Author Debadree Chatterjee (@debadree25) Branch debadree25:ft/bench-readable-read -> nodejs:main Labels benchmark, performance, author ready Commits 2 - benchmark: add a benchmark for read() of ReadableStreams - fixup! lint Committers 1 - Debadree Chatterjee PR-URL: https://github.com/nodejs/node/pull/49622 Refs: https://github.com/nodejs/performance/issues/82 Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49622 Refs: https://github.com/nodejs/performance/issues/82 Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 12 Sep 2023 10:42:20 GMT ✔ Approvals: 1 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49622#pullrequestreview-1623539599 ✘ This PR needs to wait 4 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6231626698 |
debadree25
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/49622 ✔ Done loading data for nodejs/node/pull/49622 ----------------------------------- PR info ------------------------------------ Title benchmark: add a benchmark for read() of ReadableStreams (#49622) Author Debadree Chatterjee (@debadree25) Branch debadree25:ft/bench-readable-read -> nodejs:main Labels benchmark, performance, author ready Commits 2 - benchmark: add a benchmark for read() of ReadableStreams - fixup! lint Committers 1 - Debadree Chatterjee PR-URL: https://github.com/nodejs/node/pull/49622 Refs: https://github.com/nodejs/performance/issues/82 Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49622 Refs: https://github.com/nodejs/performance/issues/82 Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 12 Sep 2023 10:42:20 GMT ✔ Approvals: 1 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49622#pullrequestreview-1623539599 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 49622 From https://github.com/nodejs/node * branch refs/pull/49622/merge -> FETCH_HEAD ✔ Fetched commits as 2ccfb23b7fc8..2f0c075a78da -------------------------------------------------------------------------------- [main de7b9357a5] benchmark: add a benchmark for read() of ReadableStreams Author: Debadree Chatterjee Date: Tue Sep 12 16:09:45 2023 +0530 1 file changed, 49 insertions(+) create mode 100644 benchmark/webstreams/readable-read.js [main b2a9f7b33f] fixup! lint Author: Debadree Chatterjee Date: Tue Sep 12 16:32:19 2023 +0530 1 file changed, 2 insertions(+), 2 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/6234511673 |
nodejs-github-bot
added
the
commit-queue-failed
debadree25
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in cd97e28 |
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
Refs: nodejs/performance#82 PR-URL: #49622 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
Refs: nodejs/performance#82 PR-URL: nodejs#49622 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at nodejs/performance#82 and trying to find a way to optimise read() realised that there is no specific benchmark for the read() function and the byob variant of read too
Refs: nodejs/performance#82