Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update output of example in mimeParams.set() #49718

Conversation

deokjinkim
Copy link
Contributor

Actual output of example in mimeParams.set() is mismatched.
So update output of example in mimeParams.set().

Expected output:

foo=def&bar=1&baz=xyz

Actual output:

foo=def;bar=1;baz=xyz

Actual output of example in `mimeParams.set()` is mismatched.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module. labels Sep 19, 2023
@deokjinkim deokjinkim added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 20, 2023
@deokjinkim deokjinkim added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit 05ebb8e into nodejs:main Sep 21, 2023
27 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 05ebb8e

ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
Actual output of example in `mimeParams.set()` is mismatched.

PR-URL: #49718
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 28, 2023
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
Actual output of example in `mimeParams.set()` is mismatched.

PR-URL: nodejs#49718
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants