-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: fix internalBinding
typings
#49742
Conversation
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing, thank you! Can you confirm that this fixes the references to ModuleWrap
in the modules code? And/or update those references in this PR?
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is helpful
Commit Queue failed- Loading data for nodejs/node/pull/49742 ✔ Done loading data for nodejs/node/pull/49742 ----------------------------------- PR info ------------------------------------ Title lib: fix `internalBinding` typings (#49742) Author Yagiz Nizipli (@anonrig) Branch anonrig:internal-binding-2023 -> nodejs:main Labels lib / src, author ready, needs-ci, typings, commit-queue-squash Commits 2 - lib: fix `internalBinding` typings - Update globals.d.ts Committers 2 - Yagiz Nizipli - GitHub PR-URL: https://github.com/nodejs/node/pull/49742 Reviewed-By: Chemi Atlow Reviewed-By: Geoffrey Booth Reviewed-By: Zeyu "Alex" Yang Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49742 Reviewed-By: Chemi Atlow Reviewed-By: Geoffrey Booth Reviewed-By: Zeyu "Alex" Yang Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 20 Sep 2023 21:55:40 GMT ✔ Approvals: 4 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/49742#pullrequestreview-1636575033 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49742#pullrequestreview-1636593235 ✔ - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/49742#pullrequestreview-1636652931 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49742#pullrequestreview-1636923558 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6279502512 |
Landed in da7962f |
PR-URL: #49742 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
PR-URL: nodejs#49742 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
I've finally found a way to fix the
internalBinding
typings for both VSCode and Clion (Intellij).